From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5E0F8BDDCC9; Thu, 15 Feb 2024 16:51:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5E0F8BDDCC9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708005083; bh=KiztVHFZ23/uh0E85woC7kqZtUeIq466hWLj5D2Anl4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TNiQcfiJ3bZIcr1VyMw6f5lw4OCyTok4JLfN1FtZnmh1LW+zGDLWpRb/4OXLQx9+B tjiqst1233kaKPmaDIq9NLHqZ5e8MbbOmGcMt5IDIk+6tgcrXpNqDITfe+Sjzg8Fu3 2idc/D7s86cikqsTtbfbqQdbK+NJVM02pLpOVqtc= Received: from smtp3.i.mail.ru (smtp3.i.mail.ru [95.163.41.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BA3EBBDDCC9 for ; Thu, 15 Feb 2024 16:51:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BA3EBBDDCC9 Received: by smtp3.i.mail.ru with esmtpa (envelope-from ) id 1rac92-00000009N3o-496g; Thu, 15 Feb 2024 16:51:21 +0300 Date: Thu, 15 Feb 2024 13:39:54 +0000 To: Sergey Bronnikov Message-ID: References: <8d9d59bf865fe5764a3c91d5a363f7e2bc78a348.1697115768.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8d9d59bf865fe5764a3c91d5a363f7e2bc78a348.1697115768.git.sergeyb@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD99B083F863FC6FF42EC5F4F79E60DB7F058691BDE7945F3E11313CFAB8367EF908E2BE116634AD74D62D413E9D711B5B2780DB38B4332ACDDD2D422C1EDFADA8AE9C3C2D3B0FDC14E4A43D3E7D3A7B3F6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D08D652E28591A78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D615E40C1C4181FBB8C67E08FE68D638DC5362CFF43A996CCC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CAD74539164518AE59735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C375AB9F4AF0B63FD1BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3045DD857D6FE754135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5679FD676284179865002B1117B3ED6969B0C85C9EE004CD0466072E6821086B3823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF77DD89D51EBB7742D3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF988B31B497C253C672BECD9E3BD563D30F8B0719777BCE057B7A0BD85771381D284AB208DE0D1BB13168784816B256848A82CED40EA6CFC931F3B892D089CFA82CB1DEF788D7FC82C226CC413062362A913E6812662D5F2A74A26541E23E71317A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojQ9gr3ZFpXElnelsnyeXzYA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D53163C5C84F018F3BD2459FBC39F2FFFE833E37713A9E05968E872FBB0CEEBFE32AF5EE5212A79745119D086FC03DADA47A24EDF3BD9585A06DEEABBE9EE6587A054198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Always snapshot functions for non-base frames. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 12.10.23, Sergey Bronnikov via Tarantool-patches wrote: > From: Sergey Bronnikov > > Reported by Arseny Vakhrushev. > Analysis and fix contributed by Peter Cawley. > > (cherry picked from commit ff1e72acead01df7d8ed0fbb31efd32f57953618) > > The problem is GC64-specific and could be reproduced with enabled > compiler options LUA_USE_ASSERT and LUA_USE_APICHECK. > > Sergey Kaplun: > * minimized reproducer made by fuzzing test > > Sergey Bronnikov: > * added the description (see a comment in the test) > * added tests for the problem: first one based on the original > reproducer and second one based on a reproducer made by fuzzing test. > > Part of tarantool/tarantool#8825 > --- > Branch: https://github.com/tarantool/luajit/commits/ligurio/lj-611-always-snapshot-functions-for-non-base-frames > PR: https://github.com/tarantool/tarantool/pull/9254 > LJ issue: https://github.com/LuaJIT/LuaJIT/issues/611 > > src/lj_record.c | 1 + > src/lj_snap.c | 9 +++- > ...t-functions-for-non-base-frames-1.test.lua | 36 +++++++++++++++ > ...hot-functions-for-non-base-frames.test.lua | 45 +++++++++++++++++++ > 4 files changed, 89 insertions(+), 2 deletions(-) > create mode 100644 test/tarantool-tests/lj-611-always-snapshot-functions-for-non-base-frames-1.test.lua > create mode 100644 test/tarantool-tests/lj-611-always-snapshot-functions-for-non-base-frames.test.lua > > -- > 2.34.1 > -- Best regards, IM