From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maksim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2] Fix recording of __concat metamethod. Date: Thu, 15 Feb 2024 13:43:22 +0000 [thread overview] Message-ID: <Zc4U-s6yWN4_Cdnm@tarantool.org> (raw) In-Reply-To: <20240202150801.80361-1-max.kokryashkin@gmail.com> Max, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/3.0 and release/2.11. On 02.02.24, Maksim Kokryashkin via Tarantool-patches wrote: > From: Mike Pall <mike> > > Reported by Elias Oelschner. Analyzed by XmiliaH. > > (cherry-picked from commit 3ee3c9cfa988339f1bf3068530515e2a6fb179d2) > > During the recording of `__concat` methametod, the `rec_mm_arith` > function overrides stack slots that are not restored for GC64 > mode later after the call. This leads to a segmentation fault > later on. This patch fixes the issue by accounting for those > additional slots in the array used for restoring stack values. > > Maxim Kokryashkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145 > --- > Changes in v2: > - Fixed comments as per review by Sergey Kaplun > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-839-concat-recording > PR: https://github.com/tarantool/tarantool/pull/9597 > Issues: https://github.com/tarantool/tarantool/issues/9145 > https://github.com/luajit/luajit/issues/839 > > src/lj_record.c | 2 +- > .../lj-839-concat-recording.test.lua | 27 +++++++++++++++++++ > 2 files changed, 28 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-839-concat-recording.test.lua > <snipped> > -- > 2.39.3 (Apple Git-145) > -- Best regards, IM
prev parent reply other threads:[~2024-02-15 13:54 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-02 15:07 Maksim Kokryashkin via Tarantool-patches 2024-02-05 10:39 ` Sergey Kaplun via Tarantool-patches 2024-02-15 13:43 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Zc4U-s6yWN4_Cdnm@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit v2] Fix recording of __concat metamethod.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox