Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization.
Date: Tue, 16 Jan 2024 15:09:37 +0300	[thread overview]
Message-ID: <ZaZyAaWquE-qX97D@root> (raw)
In-Reply-To: <4798f701-875f-4978-8455-a6d3bbfa0325@tarantool.org>

Hi, Sergey!

On 16.01.24, Sergey Bronnikov wrote:
> Hi, Max
> 
> 
> thanks for the patch!
> 
> test is passed after reverting the patch.

Do you check the GC64 build?
*NB*: You should use GC64 *without* SYSMALLOC (and hence without ASAN),
since we need to use more predictible LuaJIT's dlmalloc.

> 
> On the same build repro from the issue [1] has failed.
> 
> 
> 1. https://github.com/LuaJIT/LuaJIT/issues/840
> 
> Sergey

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2024-01-16 12:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 13:26 Maxim Kokryashkin via Tarantool-patches
2024-01-15 15:22 ` Sergey Kaplun via Tarantool-patches
2024-02-02 12:21   ` Maxim Kokryashkin via Tarantool-patches
2024-02-05  9:53     ` Sergey Kaplun via Tarantool-patches
2024-02-06 11:09       ` Maxim Kokryashkin via Tarantool-patches
2024-01-16  8:46 ` Sergey Bronnikov via Tarantool-patches
2024-01-16 12:09   ` Sergey Kaplun via Tarantool-patches [this message]
2024-01-16 12:53     ` Sergey Bronnikov via Tarantool-patches
2024-01-16 12:54 ` Sergey Bronnikov via Tarantool-patches
2024-02-15 13:42 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZaZyAaWquE-qX97D@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] LJ_GC64: Fix HREFK optimization.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox