Re: [Tarantool-patches] [PATCH luajit] Simplify handling of instable types in TNEW/TDUP load forwarding.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!

On 23.01.24, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> thanks for the patch!
> 
> Everything is fine, but a have a question -
> 
> test reproduces a problem with GC32 only, I couldn't reproduce it with GC64.
> 
> Is it expected? As I got it right, the problem is not GC-specific.

Just checked on the current master without ASAN, SYSMALLOC, COVERAGE and
got failed test:
| /home/burii/builds_workspace/luajit/master/test/tarantool-tests/lj-994-instable-types-during-loop-unroll.test.lua ........ Dubious, test returned 1 (wstat 256,
|  0x100)
| Failed 1/3 subtests
| ...
| /home/burii/builds_workspace/luajit/master/src/luajit -e 'print(require"ffi".abi"gc64")'
| true

Maybe it's affected by Coverage|ASAN flags, I don't know.

But still valid test case for GC64 build.

> 
> 
> Used CMake options:
> 
> 
> CMAKE_BUILD_TYPE="Debug"
> CMAKE_C_COMPILER="clang"
> CMAKE_EXPORT_COMPILE_COMMANDS:BOOL="TRUE"
> LUAJIT_ENABLE_COVERAGE:BOOL="TRUE"
> LUAJIT_ENABLE_GC64:BOOL="TRUE"
> LUAJIT_USE_ASAN:BOOL="TRUE"
> LUAJIT_USE_SYSMALLOC:BOOL="TRUE"
> LUA_USE_APICHECK:BOOL="TRUE"
>    LUA_USE_ASSERT:BOOL="TRUE"
> 
> 
> Sergey
> 

-- 
Best regards,
Sergey Kaplun