From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DC6D698B122; Tue, 23 Jan 2024 16:26:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DC6D698B122 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1706016378; bh=E1n0qhn+Bvb89b/qIPsKVYWWXcHmMdCYCAeBFMkdynk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vv8yiXfEDxZDJzWH/rjAJlQEHGRknXfjnUW/mAI83popYfGq2tjo65tv6VcfBMucz 9K3HYrKgVh9GF13Sy7JGp/1Cw+otfPyhfg660qUzFkm/cTCw8i9H35Yb3CX/W6JK/U XCDmVxpHR8FpeAxVEJJcJxVQU6CiAT/DTlg73geQ= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [95.163.41.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 165D498B11A for ; Tue, 23 Jan 2024 16:26:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 165D498B11A Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1rSGn9-00HAXl-1K; Tue, 23 Jan 2024 16:26:15 +0300 Date: Tue, 23 Jan 2024 16:22:01 +0300 To: Sergey Bronnikov Message-ID: References: <20240122110344.5401-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD936B5060B5AFFD53167FFB5F72E65C0ECF2FFD2CEDD3433B4182A05F5380850405CCFE85FC7EBD908E42222FB02B9CF2E44F97DA14CC3255807CE5276CEC7266C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2919D563845004AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379C6642364E0E74208638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8E24F6F6612510F9951CB326490CFD44A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C088D2E8BEBF93D4B068655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C8BDE37D78FCB031643847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A51F224F8EE7BCE33FCF1A0559EAE2AD123768244C0DDDEF18F87CCE6106E1FC07E67D4AC08A07B9B00A9EC8C3488E7643CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF5BFBB4B2AEA6259F59DBE35C76D5BC08E641CF94706680E830D5DB66EA4A7117768602CF99B169964BEAD515961AA0A76AAB9A67DB239ED7D5382DF749778DF6E48CAC7CA610320002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSQVxX8i/5XDb9HYUnSlWA== X-DA7885C5: 8A680EA79997E648408611E6A5C8FB0ABBBE9E3A6536CE7A18AE423A8AA4C189262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3361632A28BC475103080448BA546B7B100FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Simplify handling of instable types in TNEW/TDUP load forwarding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 23.01.24, Sergey Bronnikov wrote: > Hi, Sergey! > > thanks for the patch! > > Everything is fine, but a have a question - > > test reproduces a problem with GC32 only, I couldn't reproduce it with GC64. > > Is it expected? As I got it right, the problem is not GC-specific. Just checked on the current master without ASAN, SYSMALLOC, COVERAGE and got failed test: | /home/burii/builds_workspace/luajit/master/test/tarantool-tests/lj-994-instable-types-during-loop-unroll.test.lua ........ Dubious, test returned 1 (wstat 256, | 0x100) | Failed 1/3 subtests | ... | /home/burii/builds_workspace/luajit/master/src/luajit -e 'print(require"ffi".abi"gc64")' | true Maybe it's affected by Coverage|ASAN flags, I don't know. But still valid test case for GC64 build. > > > Used CMake options: > > > CMAKE_BUILD_TYPE="Debug" > CMAKE_C_COMPILER="clang" > CMAKE_EXPORT_COMPILE_COMMANDS:BOOL="TRUE" > LUAJIT_ENABLE_COVERAGE:BOOL="TRUE" > LUAJIT_ENABLE_GC64:BOOL="TRUE" > LUAJIT_USE_ASAN:BOOL="TRUE" > LUAJIT_USE_SYSMALLOC:BOOL="TRUE" > LUA_USE_APICHECK:BOOL="TRUE" >   LUA_USE_ASSERT:BOOL="TRUE" > > > Sergey > -- Best regards, Sergey Kaplun