Re: [Tarantool-patches] [PATCH luajit 07/25] test: enable <ffi_const.lua> in LuaJIT-tests

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!

Please consider my answers below.

On 23.01.24, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> thanks for the patch!
> 
> see comment below
> 
> On 1/19/24 14:32, Sergey Kaplun wrote:
> > This patch changes the `dofile()` to the corresponding `require()`.
> > Also, it names the only one test as "misc" and includes the test in
> > <index>.
> >
> > Part of tarantool/tarantool#9398
> > ---
> >   test/LuaJIT-tests/lib/ffi/ffi_const.lua | 4 ++--
> >   test/LuaJIT-tests/lib/ffi/index         | 1 +
> >   2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_const.lua b/test/LuaJIT-tests/lib/ffi/ffi_const.lua
> > index d42133ad..3213156d 100644
> > --- a/test/LuaJIT-tests/lib/ffi/ffi_const.lua
> > +++ b/test/LuaJIT-tests/lib/ffi/ffi_const.lua
> > @@ -1,6 +1,6 @@
> >   local ffi = require("ffi")
> >   
> > -dofile("../common/ffi_util.inc")
> > +local fails = require("common.fails")
> >   
> >   ffi.cdef[[
> >   typedef struct s_t {
> > @@ -41,7 +41,7 @@ typedef struct foo_t {
> >   } foo_t;
> >   ]]
> >   
> > -do
> > +do --- misc
> Why three dashes?

Three dashes are used before testcase name as a mark for test-runner.

> >     local foo_t = ffi.typeof("foo_t")
> >     local x = foo_t()
> >   
> > diff --git a/test/LuaJIT-tests/lib/ffi/index b/test/LuaJIT-tests/lib/ffi/index
> > index 9a22104a..0a72daed 100644
> > --- a/test/LuaJIT-tests/lib/ffi/index
> > +++ b/test/LuaJIT-tests/lib/ffi/index
> > @@ -6,6 +6,7 @@ ffi_arith_ptr.lua
> >   ffi_bitfield.lua
> >   ffi_call.lua
> >   ffi_callback.lua
> > +ffi_const.lua
> >   istype.lua
> >   jit_array.lua
> >   jit_complex.lua

-- 
Best regards,
Sergey Kaplun