Re: [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Pals, thanks for your reviews!

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 28.11.23, Igor Munkin wrote:
> Hello there,
> 
> The latter patch of the patchset provides the new approach for
> deterministic testing for our sampling profiler. See more info in the
> commit message.
> 
> The first patch fixes the issue occurred while reimplementing the
> sysprof test via fork(3) + ptrace(2): the output for prove was buffered
> and hence duplicated when fork is done. I decided to turn of buffering
> at all, since there is little sense in it for tests and nobody wants to
> debug many (still unrevealed) related problems.
> 
> I hope the approach will be moved to our utils for tests written in C,
> but I do not see the whole picture at the moment, so the approach is
> implemented for the only test being affected by the patch for #8594.
> 
> Branch: https://github.com/tarantool/luajit/commits/imun/sysprof-ptrace-ffunc-test
> CI: https://github.com/tarantool/luajit/commit/b48b905
> Tarantool CI: https://github.com/tarantool/tarantool/pull/9424
> Related issues:
> * https://github.com/tarantool/tarantool/issues/9387
> * https://github.com/tarantool/tarantool/issues/8594
> * https://github.com/tarantool/tarantool/issues/7900
> 
> Igor Munkin (2):
>   test: disable buffering for the C test engine
>   test: rewrite sysprof test using managed execution
> 
>  .../gh-8594-sysprof-ffunc-crash.test.c        | 269 ++++++++++++++++++
>  test/tarantool-c-tests/test.c                 |   6 +
>  .../gh-8594-sysprof-ffunc-crash.test.lua      |  55 ----
>  3 files changed, 275 insertions(+), 55 deletions(-)
>  create mode 100644 test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
>  delete mode 100644 test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua
> 
> -- 
> 2.39.2
> 

-- 
Best regards,
IM