From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine Date: Mon, 4 Dec 2023 09:50:04 +0000 [thread overview] Message-ID: <ZW2gzNrE-T0cZEv7@tarantool.org> (raw) In-Reply-To: <ZW2SAcUr6C5LnJEd@root> Sergey, Thanks for your review! On 04.12.23, Sergey Kaplun wrote: > Hi, Igor! > Thanks for the patch! > LGTM, after fixing Max's comments and my nit below. > > On 28.11.23, Igor Munkin wrote: > > <snipped> > > > --- > > test/tarantool-c-tests/test.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c > > index 7907c12a..0a370cdd 100644 > > --- a/test/tarantool-c-tests/test.c > > +++ b/test/tarantool-c-tests/test.c > > @@ -228,6 +228,12 @@ static int test_run(const struct test_unit *test, size_t test_number, > > int _test_run_group(const char *group_name, const struct test_unit tests[], > > size_t n_tests, void *test_state) > > { > > + /* > > + * XXX: Disable buffering for stdout to not mess with the > > + * output in case there are forking tests in the group. > > + */ > > + setvbuf(stdout, NULL, _IONBF, 0); > > So, we can remove `fflush(stdout);` in the `test_finish()`. Thanks for noticing. Removed. ================================================================================ diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c index 0a370cdd..c3387e9a 100644 --- a/test/tarantool-c-tests/test.c +++ b/test/tarantool-c-tests/test.c @@ -113,7 +113,6 @@ static void test_finish(size_t planned, size_t failed) if (failed > 0) test_comment("Failed %lu %s out of %lu", failed, t_type, planned); - fflush(stdout); } void test_set_skip_reason(const char *reason) ================================================================================ > > > + > > test_start_comment(group_name); > > > > level++; > > -- > > 2.39.2 > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM
next prev parent reply other threads:[~2023-12-04 9:50 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-28 14:53 [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests Igor Munkin via Tarantool-patches 2023-11-28 14:53 ` [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine Igor Munkin via Tarantool-patches 2023-12-03 12:25 ` Maxim Kokryashkin via Tarantool-patches 2023-12-04 9:48 ` Igor Munkin via Tarantool-patches 2023-12-04 8:46 ` Sergey Kaplun via Tarantool-patches 2023-12-04 9:50 ` Igor Munkin via Tarantool-patches [this message] 2023-11-28 14:53 ` [Tarantool-patches] [PATCH luajit 2/2] test: rewrite sysprof test using managed execution Igor Munkin via Tarantool-patches 2023-12-03 14:17 ` Maxim Kokryashkin via Tarantool-patches 2023-12-05 8:37 ` Sergey Kaplun via Tarantool-patches 2023-12-05 12:04 ` Igor Munkin via Tarantool-patches 2023-12-05 12:25 ` Sergey Kaplun via Tarantool-patches 2023-12-05 12:59 ` Igor Munkin via Tarantool-patches 2023-12-05 15:08 ` Sergey Kaplun via Tarantool-patches 2023-12-05 11:34 ` Igor Munkin via Tarantool-patches 2023-12-05 13:23 ` Maxim Kokryashkin via Tarantool-patches 2023-11-28 16:14 ` [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests Sergey Bronnikov via Tarantool-patches 2024-01-10 8:50 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZW2gzNrE-T0cZEv7@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox