From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 327178B7332; Mon, 4 Dec 2023 12:50:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 327178B7332 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701683445; bh=SF56dK1aiGk3CxpDHFUS6OnA3OMMeZn2QFDLK7gsnTQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Fn/jyvy3m6vVt/tNlcEkTVbiTBnVaCY4TrNRjxxd41aPniCG7CW+J949T5z/3M1R0 +da+LCpIklFwjJ/DiAel80JhWEmpWDniNZq8TA7Bsb9FKlLCQv+KwXmosmcqAwVYCn G8YqojgUKFIssJc9bNh3tkQK7g5dGZxp4ONXE82k= Received: from smtp16.i.mail.ru (smtp16.i.mail.ru [95.163.41.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3CACB8B7332 for ; Mon, 4 Dec 2023 12:50:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3CACB8B7332 Received: by smtp16.i.mail.ru with esmtpa (envelope-from ) id 1rA5b8-00AEiC-13; Mon, 04 Dec 2023 12:50:42 +0300 Date: Mon, 4 Dec 2023 09:50:04 +0000 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91486559A3ABF84E757E906D1CC3633F0810F20DA811B966D182A05F538085040C5B16B2C3F241EE9D2BA39A86E5BBA1D75962092D9DE931B7395B2308A6719FA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063779089FB2CE4EA2908638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D870265C85001E618BF4FA2506323FE461117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA93DBBCB839D0549ACD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3A040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C989FD0BDF65E50FB2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A55472954A889817E42F256D3387977348C76A1C6C3344E159F87CCE6106E1FC07E67D4AC08A07B9B01E44367C8E80A7B4CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF75F09EDD61F1CE927BC89F8387C5EC71C750541DC16EC7CBAA07F2831420E249DDCE95BB4BF576A69157FEB932BFB23DC9D0E3BFC9F83C473DAB404C104B0D14E48CAC7CA610320002C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAT457WPMCJxIOmQvLqTaWw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D53174FC0EA5ADE9A7D2F2C499450B4E08D3B5B3668FD548DDDE2326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 04.12.23, Sergey Kaplun wrote: > Hi, Igor! > Thanks for the patch! > LGTM, after fixing Max's comments and my nit below. > > On 28.11.23, Igor Munkin wrote: > > > > > --- > > test/tarantool-c-tests/test.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c > > index 7907c12a..0a370cdd 100644 > > --- a/test/tarantool-c-tests/test.c > > +++ b/test/tarantool-c-tests/test.c > > @@ -228,6 +228,12 @@ static int test_run(const struct test_unit *test, size_t test_number, > > int _test_run_group(const char *group_name, const struct test_unit tests[], > > size_t n_tests, void *test_state) > > { > > + /* > > + * XXX: Disable buffering for stdout to not mess with the > > + * output in case there are forking tests in the group. > > + */ > > + setvbuf(stdout, NULL, _IONBF, 0); > > So, we can remove `fflush(stdout);` in the `test_finish()`. Thanks for noticing. Removed. ================================================================================ diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c index 0a370cdd..c3387e9a 100644 --- a/test/tarantool-c-tests/test.c +++ b/test/tarantool-c-tests/test.c @@ -113,7 +113,6 @@ static void test_finish(size_t planned, size_t failed) if (failed > 0) test_comment("Failed %lu %s out of %lu", failed, t_type, planned); - fflush(stdout); } void test_set_skip_reason(const char *reason) ================================================================================ > > > + > > test_start_comment(group_name); > > > > level++; > > -- > > 2.39.2 > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM