From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine Date: Mon, 4 Dec 2023 09:48:43 +0000 [thread overview] Message-ID: <ZW2ge5TcwplFVRfz@tarantool.org> (raw) In-Reply-To: <3tlmhrevpsdeyhzwb32wiuzchz4efwbcgjx5fc2owlg7luloq3@53a4cidfmhcw> Max, Thanks for your review! On 03.12.23, Maxim Kokryashkin wrote: > Hi, Igor! > Thanks for the patch! > LGTM, except for a few typos in the commit message. > On Tue, Nov 28, 2023 at 02:53:16PM +0000, Igor Munkin wrote: > > Our testing engine for the tests implemented in C introduced in scope of > > the commit a0483bd214f2bbc9d7e5fc95ebc0ae13e8d22bcc ("test: introduce > > module for C tests") lazily flushes the TAP-formatted report to the > > <stdout>. This might lead to a mess in a report e.g. in case when the > Typo: s/e.g. in case/, e.g.,/ > > particular case forks a child (that inherits its <stdout>) prior to TAP > Typo: s/TAP/the TAP/ > > header is yield to <stdout>. Hence the patch disables buffering for > Typo: s/is yield/being yielded/ > Typo: s/Hence/Hence,/ > > <stdout> before any part of the TAP-formatted report is printed. > > > > Follows up tarantool/tarantool#7900 The new commit message is below. ================================================================================ test: disable buffering for the C test engine Our testing engine for the tests implemented in C introduced in scope of the commit a0483bd214f2bbc9d7e5fc95ebc0ae13e8d22bcc ("test: introduce module for C tests") lazily flushes the TAP-formatted report to the <stdout>. This might lead to a mess in a report e.g., in case when the particular case forks a child (that inherits its <stdout>) prior to the TAP header being yield to <stdout>. Hence, the patch disables buffering for <stdout> before any part of the TAP-formatted report is printed. Follows up tarantool/tarantool#7900 ================================================================================ > > > > Signed-off-by: Igor Munkin <imun@tarantool.org> > > --- <snipped> > > -- > > 2.39.2 > > -- Best regards, IM
next prev parent reply other threads:[~2023-12-04 9:49 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-28 14:53 [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests Igor Munkin via Tarantool-patches 2023-11-28 14:53 ` [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine Igor Munkin via Tarantool-patches 2023-12-03 12:25 ` Maxim Kokryashkin via Tarantool-patches 2023-12-04 9:48 ` Igor Munkin via Tarantool-patches [this message] 2023-12-04 8:46 ` Sergey Kaplun via Tarantool-patches 2023-12-04 9:50 ` Igor Munkin via Tarantool-patches 2023-11-28 14:53 ` [Tarantool-patches] [PATCH luajit 2/2] test: rewrite sysprof test using managed execution Igor Munkin via Tarantool-patches 2023-12-03 14:17 ` Maxim Kokryashkin via Tarantool-patches 2023-12-05 8:37 ` Sergey Kaplun via Tarantool-patches 2023-12-05 12:04 ` Igor Munkin via Tarantool-patches 2023-12-05 12:25 ` Sergey Kaplun via Tarantool-patches 2023-12-05 12:59 ` Igor Munkin via Tarantool-patches 2023-12-05 15:08 ` Sergey Kaplun via Tarantool-patches 2023-12-05 11:34 ` Igor Munkin via Tarantool-patches 2023-12-05 13:23 ` Maxim Kokryashkin via Tarantool-patches 2023-11-28 16:14 ` [Tarantool-patches] [PATCH luajit 0/2] Use ptrace for sysprof tests Sergey Bronnikov via Tarantool-patches 2024-01-10 8:50 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZW2ge5TcwplFVRfz@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox