Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

Thanks for your review!

On 03.12.23, Maxim Kokryashkin wrote:
> Hi, Igor!
> Thanks for the patch!
> LGTM, except for a few typos in the commit message.
> On Tue, Nov 28, 2023 at 02:53:16PM +0000, Igor Munkin wrote:
> > Our testing engine for the tests implemented in C introduced in scope of
> > the commit a0483bd214f2bbc9d7e5fc95ebc0ae13e8d22bcc ("test: introduce
> > module for C tests") lazily flushes the TAP-formatted report to the
> > <stdout>. This might lead to a mess in a report e.g. in case when the
> Typo: s/e.g. in case/, e.g.,/
> > particular case forks a child (that inherits its <stdout>) prior to TAP
> Typo: s/TAP/the TAP/
> > header is yield to <stdout>. Hence the patch disables buffering for
> Typo: s/is yield/being yielded/
> Typo: s/Hence/Hence,/
> > <stdout> before any part of the TAP-formatted report is printed.
> >
> > Follows up tarantool/tarantool#7900

The new commit message is below.

================================================================================

test: disable buffering for the C test engine

Our testing engine for the tests implemented in C introduced in scope of
the commit a0483bd214f2bbc9d7e5fc95ebc0ae13e8d22bcc ("test: introduce
module for C tests") lazily flushes the TAP-formatted report to the
<stdout>. This might lead to a mess in a report e.g., in case when the
particular case forks a child (that inherits its <stdout>) prior to the
TAP header being yield to <stdout>. Hence, the patch disables buffering
for <stdout> before any part of the TAP-formatted report is printed.

Follows up tarantool/tarantool#7900

================================================================================

> >
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---

<snipped>

> > --
> > 2.39.2
> >

-- 
Best regards,
IM