Re: [Tarantool-patches] [PATCH luajit] test: add test for conversions folding

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 17.11.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for the single nit regarding the commit message.
> On Thu, Nov 16, 2023 at 04:44:56PM +0300, Sergey Kaplun wrote:
> > This patch adds the test for commit
> > 1a401622fe83ae695226c94df3416e312315d659 ("Fix assertions."). This patch
> > removes incorrect assertions in the fold optimizations for conversions
> > from numbers to different integer types. Although the issue affects only
> Typo: s/Although/Since/

Fixed, thanks.

> > branch 2.0, there is no need to fix it. Nevertheless, the test is
> > required to avoid regressions in the future.
> >
> > Part of tarantool/tarantool#9145
> > ---
> >
> > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-833-fold-conv-from-num
> > Tarantool PR: https://github.com/tarantool/tarantool/pull/9375
> > Related issues:
> > * https://github.com/LuaJIT/LuaJIT/issues/833
> > * https://github.com/tarantool/tarantool/issues/9145
> >
> >  .../lj-833-fold-conv-from-num.test.lua        | 33 +++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >  create mode 100644 test/tarantool-tests/lj-833-fold-conv-from-num.test.lua
> <snipped>

-- 
Best regards,
Sergey Kaplun