From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and enable codespell
Date: Thu, 16 Nov 2023 16:19:51 +0000 [thread overview]
Message-ID: <ZVZBJ9WRLW8Y2Xk6@tarantool.org> (raw)
In-Reply-To: <cover.1697042800.git.sergeyb@tarantool.org>
Sergey,
I've made several touches here and there, squashed first two commits
into a single one, and finally checked the patchset into all long-term
branches in tarantool/luajit and bumped a new version in master,
release/2.11 and release/2.10.
On 11.10.23, Sergey Bronnikov via Tarantool-patches wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Sometimes we do mistakes and typos. Reviewers spend a lot of time in
> proofreading of comments, commit messages and code itself and reports
> typos to authors. The idea is to automate a part of work made by
> reviewers and highlight all typos locally or in continuous integration,
> before sending patches to review.
>
> Patches fixes typos in our own source code and enables codespell in CI.
>
> Branch: https://github.com/tarantool/luajit/tree/ligurio/gh-xxxx-spellchecking
>
> Changes v2:
>
> - removed patches with checkpatch.pl integration (CMake target and
> Github workflow)
> - added codespell integration (CMake target and Github workflow)
> - addressed Sergey's comments
>
> Sergey Bronnikov (4):
> codehealth: fix typos
> test: fix codestyle
> cmake: introduce target with codespell
> ci: enable codespell
>
<snipped>
>
> --
> 2.34.1
>
--
Best regards,
IM
prev parent reply other threads:[~2023-11-16 16:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:52 Sergey Bronnikov via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 1/4][v2] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-10-12 10:33 ` Maxim Kokryashkin via Tarantool-patches
2023-10-23 8:50 ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 2/4][v2] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-10-12 10:34 ` Maxim Kokryashkin via Tarantool-patches
2023-10-23 8:52 ` Sergey Kaplun via Tarantool-patches
2023-10-23 14:13 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:27 ` Sergey Kaplun via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 3/4][v2] cmake: introduce target with codespell Sergey Bronnikov via Tarantool-patches
2023-10-11 19:33 ` Sergey Bronnikov via Tarantool-patches
2023-10-12 10:43 ` Maxim Kokryashkin via Tarantool-patches
2023-10-12 13:28 ` Sergey Bronnikov via Tarantool-patches
2023-10-12 18:46 ` Maxim Kokryashkin via Tarantool-patches
2023-10-17 14:50 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 9:20 ` Sergey Kaplun via Tarantool-patches
2023-10-23 12:29 ` Sergey Bronnikov via Tarantool-patches
2023-10-23 14:38 ` Sergey Kaplun via Tarantool-patches
2023-10-31 6:42 ` Sergey Kaplun via Tarantool-patches
2023-10-31 10:50 ` Sergey Bronnikov via Tarantool-patches
2023-10-31 11:31 ` Sergey Kaplun via Tarantool-patches
2023-10-31 11:53 ` Maxim Kokryashkin via Tarantool-patches
2023-10-11 16:52 ` [Tarantool-patches] [PATCH luajit 4/4][v2] ci: enable codespell Sergey Bronnikov via Tarantool-patches
2023-10-12 10:45 ` Maxim Kokryashkin via Tarantool-patches
2023-10-23 8:53 ` Sergey Kaplun via Tarantool-patches
2023-11-16 16:19 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVZBJ9WRLW8Y2Xk6@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH luajit 0/4][v2] Fix typos and enable codespell' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox