Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers
Date: Thu, 23 Nov 2023 06:33:02 +0000	[thread overview]
Message-ID: <ZV7yHuJe3VTf--J0@tarantool.org> (raw)
In-Reply-To: <1b01124ea966b486d9462dea0d3653a45c4f81b1.1693481682.git.m.kokryashkin@tarantool.org>

Max,

I've checked this patch into all long-term branches in tarantool/luajit
and bumped a new version in master, release/2.11 and release/2.10.

On 31.08.23, Maxim Kokryashkin via Tarantool-patches wrote:
> It is really inconvenient to use a standalone shell script to parse
> binary dumps from profilers. That is why this commit introduces a
> CLI flag for tools in the LuaJIT, so now it is possible to parse
> a memprof dump as simple as:
> ```
> luajit -tm memprof.bin
> luajit -tm --leak-only memprof.bin
> ```
> 
> And the sysprof too:
> ```
> luajit -ts sysprof.bin
> luajit -ts --split sysprof.bin
> ```
> 
> The `luajit-parse-memprof` and `luajit-parse-sysprof` are purged
> as a result of these changes.
> 
> Closes tarantool/tarantool#5688
> ---
>  Makefile.original                             |  24 +---
>  src/luajit.c                                  |  44 +++++-
>  .../gh-5688-tool-cli-flag.test.lua            | 127 ++++++++++++++++++
>  tools/CMakeLists.txt                          |  73 ----------
>  tools/luajit-parse-memprof.in                 |   6 -
>  tools/luajit-parse-sysprof.in                 |   6 -
>  tools/memprof.lua                             |  12 +-
>  tools/sysprof.lua                             |  18 ++-
>  8 files changed, 186 insertions(+), 124 deletions(-)
>  create mode 100644 test/tarantool-tests/gh-5688-tool-cli-flag.test.lua
>  delete mode 100755 tools/luajit-parse-memprof.in
>  delete mode 100755 tools/luajit-parse-sysprof.in
> 

<snipped>

> -- 
> 2.41.0
> 

-- 
Best regards,
IM

  parent reply	other threads:[~2023-11-23  6:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-31 11:35 [Tarantool-patches] [PATCH luajit v9 0/2] introduce cli for tools Maxim Kokryashkin via Tarantool-patches
2023-08-31 11:35 ` [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers Maxim Kokryashkin via Tarantool-patches
2023-09-03  9:50   ` Sergey Kaplun via Tarantool-patches
2023-09-04  9:30     ` Maxim Kokryashkin via Tarantool-patches
2023-09-07  9:41   ` Sergey Bronnikov via Tarantool-patches
2023-09-12 20:03     ` Maxim Kokryashkin via Tarantool-patches
2023-09-14  9:22       ` Sergey Bronnikov via Tarantool-patches
2023-09-18  8:51         ` Maxim Kokryashkin via Tarantool-patches
2023-10-04  8:58           ` Sergey Bronnikov via Tarantool-patches
2023-10-04 11:49             ` Maxim Kokryashkin via Tarantool-patches
2023-10-06  8:26               ` Sergey Bronnikov via Tarantool-patches
2023-11-23  6:33   ` Igor Munkin via Tarantool-patches [this message]
2023-08-31 11:35 ` [Tarantool-patches] [PATCH luajit v9 2/2] test: don't skip tool CLI flag for tarantool Maxim Kokryashkin via Tarantool-patches
2023-09-03  9:54   ` Sergey Kaplun via Tarantool-patches
2023-09-07  9:42   ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZV7yHuJe3VTf--J0@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox