Re: [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 08.11.23, Maksim Kokryashkin via Tarantool-patches wrote:
> Changes in v2:
> - Fixed comments as per review by Sergey Kaplun. See my answers
> in the corresponding patch.
> 
> V1: https://lists.tarantool.org/tarantool-patches/20231027125738.29527-1-max.kokryashkin@gmail.com/T/#t
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-946-print-errors-from-gc-fin
> PR: https://github.com/tarantool/tarantool/pull/9315
> Issues:
> https://github.com/LuaJIT/LuaJIT/pull/946
> https://github.com/LuaJIT/LuaJIT/issues/991
> https://github.com/tarantool/tarantool/issues/9145
> 
> Mike Pall (2):
>   Print errors from __gc finalizers instead of rethrowing them.
>   Fix last commit.
> 
>  src/Makefile.dep.original                     | 14 +++----
>  src/lib_aux.c                                 | 35 +++++++++++++++-
>  src/lj_gc.c                                   | 10 ++++-
>  src/lj_vmevent.h                              |  7 ++--
>  test/PUC-Rio-Lua-5.1-tests/gc.lua             | 12 +++---
>  ...91-fix-finalizer-error-handler-init.test.c | 30 +++++++++++++
>  ...6-print-errors-from-gc-fin-custom.test.lua | 42 +++++++++++++++++++
>  ...-print-errors-from-gc-fin-default.test.lua | 11 +++++
>  .../script.lua                                | 24 +++++++++++
>  9 files changed, 165 insertions(+), 20 deletions(-)
>  create mode 100644 test/tarantool-c-tests/lj-991-fix-finalizer-error-handler-init.test.c
>  create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua
>  create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua
>  create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua
> 
> --
> 2.39.3 (Apple Git-145)
> 

-- 
Best regards,
IM