From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D1BC06EB730; Thu, 23 Nov 2023 09:35:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D1BC06EB730 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1700721347; bh=Y4+PFJRgFP6pICwujAx3lA7nhsIOm2dYLA7z6Y9znzI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=E/wD0Zsp+nfjqoMo4fWKJwWTO95zjx/973/F5MHE73G4DUtsFoTDtJ/ZZXgHzCm7F xCmyBKpPJsU90DmJ+XEA9Es5GKc9yYrN9Ws9KBCWPjPDtnIcaK1A3QjijYKhueHFHP LcFYMyqlWAwK8qe9Y1Sr/gxW2rEtlMtQdXhLzHNg= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 05FBB6EB730 for ; Thu, 23 Nov 2023 09:34:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 05FBB6EB730 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1r63Ia-00Eh3d-0m; Thu, 23 Nov 2023 09:34:52 +0300 Date: Thu, 23 Nov 2023 06:30:28 +0000 To: Maksim Kokryashkin Message-ID: References: <20231107210616.53138-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231107210616.53138-1-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92D71B79D2A671AE6422F1D012930A708C4696DB667808124182A05F5380850408C5CAD5E6ED802A4CF050C8D660CD0A7C1F32AE6177F37C1130D83BCD4DDFD1F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE731D82F3F177D3BCDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637802D3462438662818638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F769B34609C11D968770BB0A949F8BC8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB1593CA6EC85F86DFCE65BE3358055BDD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3457EE4B4996FC54603F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CD2DCF9CF1F528DBC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F616AD31D0D18CD5C35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A519D378DFC340D525052B7CC51BDC914855B2F8746AAC91C1F87CCE6106E1FC07E67D4AC08A07B9B0735DFC8FA7AC1207CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF5E012008251BF506A7D194E0240C6A6626A3A2562E0661185A13252A5C06D086A8F268452FA2DF716E159192F517E671D9F1911388F29F11A7B35A8DB0F1EAD7461A413F07889F2102C26D483E81D6BEECAEF3E2CCC1ED8C383653B6C8D9AE0FD16FCAA6493B703A X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojOz05VK5QHNoQeAMYGxjeJA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531C191C8E96013370FA97B50B48FC9E91851C05F07CCC97CB22326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 08.11.23, Maksim Kokryashkin via Tarantool-patches wrote: > Changes in v2: > - Fixed comments as per review by Sergey Kaplun. See my answers > in the corresponding patch. > > V1: https://lists.tarantool.org/tarantool-patches/20231027125738.29527-1-max.kokryashkin@gmail.com/T/#t > Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-946-print-errors-from-gc-fin > PR: https://github.com/tarantool/tarantool/pull/9315 > Issues: > https://github.com/LuaJIT/LuaJIT/pull/946 > https://github.com/LuaJIT/LuaJIT/issues/991 > https://github.com/tarantool/tarantool/issues/9145 > > Mike Pall (2): > Print errors from __gc finalizers instead of rethrowing them. > Fix last commit. > > src/Makefile.dep.original | 14 +++---- > src/lib_aux.c | 35 +++++++++++++++- > src/lj_gc.c | 10 ++++- > src/lj_vmevent.h | 7 ++-- > test/PUC-Rio-Lua-5.1-tests/gc.lua | 12 +++--- > ...91-fix-finalizer-error-handler-init.test.c | 30 +++++++++++++ > ...6-print-errors-from-gc-fin-custom.test.lua | 42 +++++++++++++++++++ > ...-print-errors-from-gc-fin-default.test.lua | 11 +++++ > .../script.lua | 24 +++++++++++ > 9 files changed, 165 insertions(+), 20 deletions(-) > create mode 100644 test/tarantool-c-tests/lj-991-fix-finalizer-error-handler-init.test.c > create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua > create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua > create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua > > -- > 2.39.3 (Apple Git-145) > -- Best regards, IM