Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for x-0.
Date: Thu, 23 Nov 2023 06:29:30 +0000	[thread overview]
Message-ID: <ZV7xSsJQieLK7KX7@tarantool.org> (raw)
In-Reply-To: <20231031124446.17478-1-skaplun@tarantool.org>

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 31.10.23, Sergey Kaplun via Tarantool-patches wrote:
> From: Mike Pall <mike>
> 
> Reported by XmiliaH.
> 
> (cherry-picked from commit 7b994e0ee0399caf6319865bbac88ddf62129a36)
> 
> Fold optimization x - (-0) ==> x is INVALID for x = -0 in FP arithmetic.
> Its result is -0 instead of +0. This patch allows only x - (+0) ==> x
> optimization.
> 
> Sergey Kaplun:
> * added the description and the test for the problem
> 
> Part of tarantool/tarantool#9145
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-783-fix-fold-x-0
> Tarantool PR: https://github.com/tarantool/tarantool/pull/9320
> Related Issues:
> * https://github.com/tarantool/tarantool/issues/9145
> * https://github.com/LuaJIT/LuaJIT/pull/783
> 
>  src/lj_opt_fold.c                            |  3 +--
>  test/tarantool-tests/lj-783-fold--0.test.lua | 28 ++++++++++++++++++++
>  2 files changed, 29 insertions(+), 2 deletions(-)
>  create mode 100644 test/tarantool-tests/lj-783-fold--0.test.lua
> 

<snipped>

> -- 
> 2.42.0
> 

-- 
Best regards,
IM

      parent reply	other threads:[~2023-11-23  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 12:44 Sergey Kaplun via Tarantool-patches
2023-10-31 15:17 ` Maxim Kokryashkin via Tarantool-patches
2023-11-08 19:36 ` Sergey Bronnikov via Tarantool-patches
2023-11-23  6:29 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZV7xSsJQieLK7KX7@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for x-0.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox