Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maksim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Prevent compile of __concat with tailcall to fast function.
Date: Thu, 23 Nov 2023 06:29:20 +0000	[thread overview]
Message-ID: <ZV7xQO5FRtVMOcw2@tarantool.org> (raw)
In-Reply-To: <20231025114047.55743-1-max.kokryashkin@gmail.com>

Max,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 25.10.23, Maksim Kokryashkin via Tarantool-patches wrote:
> From: Mike Pall <mike>
> 
> E.g. __concat = function() return setmetatable(...) end
> Reported by Fezile Manana.
> 
> (cherry-picked from commit 75ee3a6159f1831fa57992df3caf5a2c303c281a)
> 
> During the recording of concat with tailcall to fast function,
> the fast function recording is postponed. This implementation
> may lead to the absence of side effects from fast-function and
> incorrect behavior as a result. For a comprehensive example,
> see the comment in the test.
> 
> Maxim Kokryashkin:
> * added the description and the test for the problem
> 
> Part of tarantool/tarantool#9145
> ---
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-690-concat-tail-call
> PR: https://github.com/tarantool/tarantool/pull/9304
> Issue: https://github.com/LuaJIT/LuaJIT/issues/690
> 
>  src/lj_record.c                               |  3 ++
>  .../lj-690-concat-tail-call.test.lua          | 34 +++++++++++++++++++
>  2 files changed, 37 insertions(+)
>  create mode 100644 test/tarantool-tests/lj-690-concat-tail-call.test.lua
> 

<snipped>

> --
> 2.39.3 (Apple Git-145)
> 

-- 
Best regards,
IM

      parent reply	other threads:[~2023-11-23  6:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 11:40 Maksim Kokryashkin via Tarantool-patches
2023-10-25 13:10 ` Sergey Kaplun via Tarantool-patches
2023-11-08 16:42 ` Sergey Bronnikov via Tarantool-patches
2023-11-23  6:29 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZV7xQO5FRtVMOcw2@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Prevent compile of __concat with tailcall to fast function.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox