Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] x86/x64: Fix math.ceil(-0.9) result sign.
Date: Thu, 9 Nov 2023 17:32:53 +0300	[thread overview]
Message-ID: <ZUztlVUW3TQ_1aXr@root> (raw)
In-Reply-To: <8b05c3f3-7c71-4960-ae08-1bb707793485@tarantool.org>

Hi, Sergey!
Thanks for the review!
Fixed your comment inline, see the iterative patch below.
Branch is rebased and force-pushed.

diff --git a/test/tarantool-tests/lj-859-math-ceil-sign.test.lua b/test/tarantool-tests/lj-859-math-ceil-sign.test.lua
index 831b6480..a67de888 100644
--- a/test/tarantool-tests/lj-859-math-ceil-sign.test.lua
+++ b/test/tarantool-tests/lj-859-math-ceil-sign.test.lua
@@ -11,7 +11,7 @@ test:plan(1)
 local IS_DUALNUM = tostring(tonumber('-0')) ~= tostring(-0)
 local IS_X86_64 = jit.arch == 'x86' or jit.arch == 'x64'
--- Use `tostirng()` to compare the sign of the returned value.
+-- Use `tostring()` to compare the sign of the returned value.
 -- Take any value from the mentioned range. The chosen one is
 -- mentioned in the commit message.
 test:ok((IS_DUALNUM and IS_X86_64) or tostring(math.ceil(-0.9)) == '-0',

Best regards,
Sergey Kaplun

  reply	other threads:[~2023-11-09 14:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 12:36 Sergey Kaplun via Tarantool-patches
2023-11-07  9:44 ` Maxim Kokryashkin via Tarantool-patches
2023-11-07 10:21   ` Sergey Kaplun via Tarantool-patches
2023-11-07 10:50     ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 13:26 ` Sergey Bronnikov via Tarantool-patches
2023-11-09 14:32   ` Sergey Kaplun via Tarantool-patches [this message]
2023-11-09 16:04     ` Sergey Bronnikov via Tarantool-patches
2023-11-23  6:31 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUztlVUW3TQ_1aXr@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] x86/x64: Fix math.ceil(-0.9) result sign.' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox