From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0030A64EFB6; Thu, 9 Nov 2023 17:37:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0030A64EFB6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1699540649; bh=vq/oQQUsZYmwx/ibjojz7CUHldtqZXpmM1ajgn2XsKM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=l76wfRVAN97R6HhGKpbrhYxKVabrdGy6ATk/fGlQCAKvoLy9p/vSzm1bmwZ/iLQbJ 1BlukpP4UucGtoYZDpOc4/RK5iRkxD+cDA6ODcPPpNfpbMnUHiDJTnTjJ3rmMg76VH pfk2Hf6kLLrmvU4bSLcKoN0wmUe1/QpWQ2pDA/3c= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 802DA64ED28 for ; Thu, 9 Nov 2023 17:37:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 802DA64ED28 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1r169u-0005Hc-KY; Thu, 09 Nov 2023 17:37:27 +0300 Date: Thu, 9 Nov 2023 17:32:53 +0300 To: Sergey Bronnikov Message-ID: References: <20231102123616.10527-1-skaplun@tarantool.org> <8b05c3f3-7c71-4960-ae08-1bb707793485@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b05c3f3-7c71-4960-ae08-1bb707793485@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9C2A6B03AB739174C257DF95037FE5E5EC8239E2FC8E2FDC300894C459B0CD1B998ECD731F780A93B2D7F63E441693C2F937FEBAC6102B48D3E51E86926A75756 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7D3DF794D859AA4BFEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD871551502E69220FAEB1D1886B122784EAECC7F00164DA146DAFE8445B8C89999728AA50765F79006370D9A29B7FD16D1239FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3776A0366D588B3C3117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F890A246B268E114E42539A7722CA490CB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5775E77D3821BD975B321190434E14BAB59C2FF190DBE62F6F87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF113DE328CCBF5091F112EB7FD13823C37BFED4379C031ADC9C9B66E87C95D7A6FD9AF20B71F72F3AD0DB820CB2E38D8BA25AD9D01678E53FA47B209857450C6EE48CAC7CA610320002C26D483E81D6BE5EF9655DD6DEA7D65774BB76CC95456EEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKdAcnY08CHKvzc9ZlgtnMA== X-DA7885C5: EDD9FF8EE46ACB4BBF73B883F054DFD7059EE8A1713FFE5B3A3029665D2B96B9262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE3383A9F12B85EAF04D434E595E2FE251370FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] x86/x64: Fix math.ceil(-0.9) result sign. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment inline, see the iterative patch below. Branch is rebased and force-pushed. =================================================================== diff --git a/test/tarantool-tests/lj-859-math-ceil-sign.test.lua b/test/tarantool-tests/lj-859-math-ceil-sign.test.lua index 831b6480..a67de888 100644 --- a/test/tarantool-tests/lj-859-math-ceil-sign.test.lua +++ b/test/tarantool-tests/lj-859-math-ceil-sign.test.lua @@ -11,7 +11,7 @@ test:plan(1) local IS_DUALNUM = tostring(tonumber('-0')) ~= tostring(-0) local IS_X86_64 = jit.arch == 'x86' or jit.arch == 'x64' --- Use `tostirng()` to compare the sign of the returned value. +-- Use `tostring()` to compare the sign of the returned value. -- Take any value from the mentioned range. The chosen one is -- mentioned in the commit message. test:ok((IS_DUALNUM and IS_X86_64) or tostring(math.ceil(-0.9)) == '-0', =================================================================== -- Best regards, Sergey Kaplun