From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>, Igor Munkin <imun@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Fix pragma push stack limit check and throw on overflow. Date: Thu, 9 Nov 2023 08:57:05 +0300 [thread overview] Message-ID: <ZUx0sTw6B-zM7lAr@root> (raw) In-Reply-To: <20231108084044.6654-1-skaplun@tarantool.org> Hi, folks! Thanks for the review! Your comments are fixed, branch is rebased on master and force-pushed. See iterative diff below. =================================================================== diff --git a/test/tarantool-tests/lj-1114-ffi-pragma-pack.test.lua b/test/tarantool-tests/lj-1114-ffi-pragma-pack.test.lua index e5642828..99b98900 100644 --- a/test/tarantool-tests/lj-1114-ffi-pragma-pack.test.lua +++ b/test/tarantool-tests/lj-1114-ffi-pragma-pack.test.lua @@ -5,7 +5,7 @@ local tap = require('tap') -- See also: https://github.com/LuaJIT/LuaJIT/issues/1114. local test = tap.test('lj-1114-ffi-pragma-pack') -local ffi = require 'ffi' +local ffi = require('ffi') test:plan(2) @@ -37,7 +37,7 @@ end local err, msg = pcall(ffi_cdef_wp) -test:ok(not err, 'the error is thrown when couner overflows') +test:ok(not err, 'the error is thrown when counter overflows') test:like(msg, 'chunk has too many syntax levels', 'the error message is correct') =================================================================== -- Best regards, Sergey Kaplun
next prev parent reply other threads:[~2023-11-09 6:01 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-08 8:40 Sergey Kaplun via Tarantool-patches 2023-11-08 18:39 ` Igor Munkin via Tarantool-patches 2023-11-08 18:59 ` Maxim Kokryashkin via Tarantool-patches 2023-11-09 5:57 ` Sergey Kaplun via Tarantool-patches [this message] 2023-11-23 6:31 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZUx0sTw6B-zM7lAr@root \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] FFI: Fix pragma push stack limit check and throw on overflow.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox