From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Fix base register coalescing in side trace. Date: Tue, 7 Nov 2023 18:42:31 +0000 [thread overview] Message-ID: <ZUqFF9l5cXMkz8dt@tarantool.org> (raw) In-Reply-To: <2756cdf8d8a4be9aa55dfdadbd3453da067d8969.1697034851.git.skaplun@tarantool.org> Sergey, Thanks for the patch! LGTM, except a typo below. On 11.10.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall <mike> > > Thanks to Sergey Kaplun, NiLuJe and Peter Cawley. > > (cherry-picked from commit aa2db7ebd1267836af5221336ccb4e9b4aa8372d) > > The previous patch fixed just part of the problem with the register > coalesing. For example, the parent base register may be used inside the Typo: s/coalesing/coalescing. > parent or child register sets when it shouldn't. This leads to incorrect > register allocations, which may lead to crashes or undefined behaviour. > This patch fixes it by excluding the parent base register from both > register sets. > > The test case for this patch doesn't fail before the commit since it > requires specific register allocation, which is hard to construct and > very fragile. Due to the lack of ideal sync with the upstream > repository, the test is passed before the patch. > It should become correct in future patches. > > Resolves tarantool/tarantool#8767 > Part of tarantool/tarantool#9145 > > Sergey Kaplun: > * added the description and the test for the problem > --- > src/lj_asm.c | 7 +- > src/lj_asm_arm.h | 7 +- > src/lj_asm_arm64.h | 7 +- > src/lj_asm_mips.h | 8 +- > src/lj_asm_ppc.h | 8 +- > src/lj_asm_x86.h | 8 +- > .../lj-1031-asm-head-side-base-reg.test.lua | 139 ++++++++++++++++++ > 7 files changed, 163 insertions(+), 21 deletions(-) > create mode 100644 test/tarantool-tests/lj-1031-asm-head-side-base-reg.test.lua > <snipped> > -- > 2.42.0 > -- Best regards, IM
next prev parent reply other threads:[~2023-11-07 18:44 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-11 15:04 [Tarantool-patches] [PATCH luajit 0/2] Fix assembling of the head of side traces Sergey Kaplun via Tarantool-patches 2023-10-11 15:04 ` [Tarantool-patches] [PATCH luajit 1/2] Fix register mask for stack check in head of side trace Sergey Kaplun via Tarantool-patches 2023-10-13 5:48 ` Maxim Kokryashkin via Tarantool-patches 2023-10-23 9:27 ` Sergey Kaplun via Tarantool-patches 2023-10-24 13:51 ` Maxim Kokryashkin via Tarantool-patches 2023-11-07 18:42 ` Igor Munkin via Tarantool-patches 2023-10-11 15:04 ` [Tarantool-patches] [PATCH luajit 2/2] Fix base register coalescing in " Sergey Kaplun via Tarantool-patches 2023-10-13 5:59 ` Maxim Kokryashkin via Tarantool-patches 2023-10-23 9:50 ` Sergey Kaplun via Tarantool-patches 2023-10-24 13:50 ` Maxim Kokryashkin via Tarantool-patches 2023-11-07 18:42 ` Igor Munkin via Tarantool-patches [this message] 2023-11-23 6:30 ` [Tarantool-patches] [PATCH luajit 0/2] Fix assembling of the head of side traces Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZUqFF9l5cXMkz8dt@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 2/2] Fix base register coalescing in side trace.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox