Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Fix register mask for stack check in head of side trace.
Date: Tue, 7 Nov 2023 18:42:19 +0000	[thread overview]
Message-ID: <ZUqFC7Fgz_0zVx5O@tarantool.org> (raw)
In-Reply-To: <9b2713c1405073d42c14f3179ff5a8fb338a37dd.1697034851.git.skaplun@tarantool.org>

Sergey,

Thanks for the patch! LGTM. I have no idea regarding the test either,
since the condition for reproducing is definitely rather fragile.

-- 
Best regards,
IM

  parent reply	other threads:[~2023-11-07 18:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 15:04 [Tarantool-patches] [PATCH luajit 0/2] Fix assembling of the head of side traces Sergey Kaplun via Tarantool-patches
2023-10-11 15:04 ` [Tarantool-patches] [PATCH luajit 1/2] Fix register mask for stack check in head of side trace Sergey Kaplun via Tarantool-patches
2023-10-13  5:48   ` Maxim Kokryashkin via Tarantool-patches
2023-10-23  9:27     ` Sergey Kaplun via Tarantool-patches
2023-10-24 13:51       ` Maxim Kokryashkin via Tarantool-patches
2023-11-07 18:42   ` Igor Munkin via Tarantool-patches [this message]
2023-10-11 15:04 ` [Tarantool-patches] [PATCH luajit 2/2] Fix base register coalescing in " Sergey Kaplun via Tarantool-patches
2023-10-13  5:59   ` Maxim Kokryashkin via Tarantool-patches
2023-10-23  9:50     ` Sergey Kaplun via Tarantool-patches
2023-10-24 13:50       ` Maxim Kokryashkin via Tarantool-patches
2023-11-07 18:42   ` Igor Munkin via Tarantool-patches
2023-11-23  6:30 ` [Tarantool-patches] [PATCH luajit 0/2] Fix assembling of the head of side traces Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUqFC7Fgz_0zVx5O@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] Fix register mask for stack check in head of side trace.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox