Re: [Tarantool-patches] [PATCH luajit] Fix Clang build.

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 03.10.23, Maksim Kokryashkin via Tarantool-patches wrote:
> From: Mike Pall <mike>
> 
> (cherry-picked from commit 384d6d56f4a3841fdef607a511dda92a579af2ff)
> 
> The `__GNUC__` macro signals that GNU extensions are supported
> by a compiler. Some versions of the clang compiler
> (clang 10.0.0 targeting the MSVC ABI, for example) may not
> define that macro. However, they still support the GNU
> extensions. This patch fixes the build for those compilers
> by checking the `__clang__` macro value alongside `__GNUC__`.
> 
> Part of the patch relevant to 'lj_err.c' is omitted since all
> of the required changes were already backported in the scope
> of the patch b6d285214db9892aaef838950d200f395c93fe2d ('Cleanup
> and enable external unwinding for more platforms.').
> 
> No tests were added since the issue is relevant for a very
> specific type of very old clang 10.0.0, which is not really
> relevant for us.
> 
> Maxim Kokryashkin:
> * added the description for the problem
> 
> Part of tarantool/tarantool#9145
> ---
> PR: https://github.com/tarantool/tarantool/pull/9215
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-595-fix-clang-build
> Issue: https://github.com/luajit/luajit/issues/595
>  src/lj_alloc.c    | 2 +-
>  src/lj_def.h      | 4 ++--
>  src/lj_emit_x86.h | 2 +-
>  src/lj_ircall.h   | 2 +-
>  src/lj_mcode.c    | 2 +-
>  src/lj_strfmt.h   | 2 +-
>  src/lj_strscan.c  | 2 +-
>  7 files changed, 8 insertions(+), 8 deletions(-)
> 

<snipped>

> --
> 2.39.3 (Apple Git-145)
> 

-- 
Best regards,
IM