From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <estetus@gmail.com> Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit][v2] LJ_GC64: Fix lua_concat(). Date: Tue, 31 Oct 2023 16:00:05 +0000 [thread overview] Message-ID: <ZUEkhSdVPtwo4F9D@tarantool.org> (raw) In-Reply-To: <a84e3f6c45ebb1e290253ff2d375b9253b87fe56.1696601471.git.sergeyb@tarantool.org> Sergey, I didn't find the patch where <assert_str_equal>/<assert_str_not_equal> are introduced. Furthermore, I'd rather recommend to introduce <assert_str0_equal>/<assert_str0_not_equal> comparing nul-terminated strings, so length is not required (it's just a simple wrapper around the functions you've already implemented). Anyway, I'd like to ask you to send the aforementioned patch. -- Best regards, IM
next prev parent reply other threads:[~2023-10-31 16:01 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-06 14:15 Sergey Bronnikov via Tarantool-patches 2023-10-08 14:58 ` Maxim Kokryashkin via Tarantool-patches 2023-10-09 14:11 ` Sergey Kaplun via Tarantool-patches 2023-10-10 12:33 ` Sergey Bronnikov via Tarantool-patches 2023-10-31 16:00 ` Igor Munkin via Tarantool-patches [this message] 2023-10-31 18:14 ` Sergey Bronnikov via Tarantool-patches 2023-10-31 19:22 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZUEkhSdVPtwo4F9D@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit][v2] LJ_GC64: Fix lua_concat().' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox