Re: [Tarantool-patches] [PATCH luajit 2/6] FFI: Fix missing cts->L initialization in argv2ctype().

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!
Please, consider my answer below.

On 24.10.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few nits regarding the commit message.
> On Mon, Oct 23, 2023 at 12:22:02PM +0300, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> > 
> > (cherry-picked from commit 50d6883e6027c4c2f9a5e495fee6b7fff1bd73c9)
> Incorrect hash, should be: a622e2eb559c823d90c7af85935ca63706e4593d
> > 
> > When start trace recording without an initialized `L` in CType State
> > (possible if the recording is started before any `ffi` library usage),
> > the corresponding assertion fails in the `lj_ctype_intern()`. This patch
> > adds missing initialization during recording.
> 
> Please explicitly mention that the test case fails only when the LuaJIT
> is built with -DLUA_USE_ASSERT=ON.

> > the corresponding assertion fails in the `lj_ctype_intern()`. This patch
It's obvious since there are no assertions if this option is set to OFF.

So, ignoring.

> > 
> > Sergey Kaplun:
> > * added the description and the test for the problem
> > 
> > Part of tarantool/tarantool#9145
> > ---
> <snipped>
> Best regards,
> Maxim Kokryashkin 
>  

-- 
Best regards,
Sergey Kaplun