From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maksim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix Clang build.
Date: Mon, 9 Oct 2023 12:13:51 +0300 [thread overview]
Message-ID: <ZSPETyfzZ3B7qPSK@root> (raw)
In-Reply-To: <20231003151133.13730-1-max.kokryashkin@gmail.com>
Hi, Max!
Thanks for the patch!
Please, consider my comment below.
On 03.10.23, Maksim Kokryashkin wrote:
> From: Mike Pall <mike>
>
<snipped>
>
> No tests were added since the issue is relevant for a very
> specific type of very old clang 10.0.0, which is not really
> relevant for us.
Indeed, but we should add the testing of clang build to our CI.
I suppose we may check the following matrix:
- [GC64, !GC64]
- [Debug, Release]
- Linux only
ARM64 may be omitted for now since it isn't our target platform.
It should be done aside from ASAN testing just to verify correctness
under this compiler. Should be easily added to the `test-luajit` matrix
in the <.github/workflows/testing.yml>:
>
> Maxim Kokryashkin:
> * added the description for the problem
>
> Part of tarantool/tarantool#9145
> ---
> PR: https://github.com/tarantool/tarantool/pull/9215
> Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-595-fix-clang-build
> Issue: https://github.com/luajit/luajit/issues/595
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2023-10-09 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 15:11 Maksim Kokryashkin via Tarantool-patches
2023-10-03 15:47 ` Sergey Bronnikov via Tarantool-patches
2023-10-09 9:13 ` Sergey Kaplun via Tarantool-patches [this message]
2023-10-18 10:01 ` Maxim Kokryashkin via Tarantool-patches
2023-10-22 1:52 ` Sergey Kaplun via Tarantool-patches
2023-11-07 13:30 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSPETyfzZ3B7qPSK@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Fix Clang build.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox