From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Bronnikov <estetus@gmail.com> Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (again). Date: Wed, 27 Sep 2023 12:33:15 +0000 [thread overview] Message-ID: <ZRQhCzvOf9mMeNmN@tarantool.org> (raw) In-Reply-To: <8b2d744f68eb138c2b2c37e1ac851181e303b485.1693305720.git.sergeyb@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 29.08.23, Sergey Bronnikov via Tarantool-patches wrote: > From: sergeyb@tarantool.org > > Reported by Sergey Bronnikov. #1054 > > (cherry picked from commit 309fb42b871b6414f53e0e0e708bce0b0d62daff) > > The following Lua snippet triggers an out of boundary access to a stack: > > ```lua > a, b, c = 1, 2, 3 > local d > for _ in nil do end > ``` > > With execution snippet by LuaJIT instrumented by ASAN it leads to > a heap-buffer-overflow. > > In a function `predict_next` variable `exprpc` looks forward and expects > extra bytecodes on the stack. However, `KPRI` is merged to the `KNIL` > and there is no new bytecode to add, so `exprpc == fs->bclim` and it > leads to out of boundary access. > > Sergey Bronnikov: > * added the description and the test for the problem > > Part of tarantool/tarantool#8825 > --- > > PR: https://github.com/tarantool/tarantool/pull/9054 > Branch: https://github.com/tarantool/luajit/tree/ligurio/lj-1054-incorrect-pc-value-predict_next > Related issue: > * https://github.com/LuaJIT/LuaJIT/issues/1054 > > src/lj_parse.c | 4 +++- > ...incorrect-pc-value-in-predict_next.test.lua | 18 ++++++++++++++++++ > 2 files changed, 21 insertions(+), 1 deletion(-) > create mode 100644 test/tarantool-tests/lj-1054-incorrect-pc-value-in-predict_next.test.lua > <snipped> > -- > 2.34.1 > -- Best regards, IM
prev parent reply other threads:[~2023-09-27 12:54 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-29 10:42 Sergey Bronnikov via Tarantool-patches 2023-08-29 13:38 ` Sergey Kaplun via Tarantool-patches 2023-08-29 14:38 ` Sergey Bronnikov via Tarantool-patches 2023-08-29 14:43 ` Sergey Kaplun via Tarantool-patches 2023-08-29 15:11 ` Sergey Bronnikov via Tarantool-patches 2023-08-30 10:53 ` Maxim Kokryashkin via Tarantool-patches 2023-08-31 11:48 ` Sergey Bronnikov via Tarantool-patches 2023-09-27 12:33 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZRQhCzvOf9mMeNmN@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=estetus@gmail.com \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix predict_next() in parser (again).' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox