From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>, Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Always exit after machine code page protection change fails. Date: Wed, 27 Sep 2023 12:33:02 +0000 [thread overview] Message-ID: <ZRQg/k04efjoyqMD@tarantool.org> (raw) In-Reply-To: <b6523001e748a65c28d273ba7f07bdab373135c6.1693569587.git.imun@tarantool.org> Pals, thanks for your reviews! I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 01.09.23, Igor Munkin wrote: > From: Mike Pall <mike> > > Reported by Sergey Kaplun. > > (cherry picked from commit c50232eb320d56d526ba5e6cb5bda8cf5a848a55) > > Unfortunately, <exit> call had been missing for a long time for the case > when <mprotect> fails within <mcode_protect>. Though the patch per se is > quite trivial, the test is not at all. It exploits the fact, that > <mprotect> is used only for protecting area for mcode or callback > function pointers. Hence, if the test doesn't use FFI at all, it is > guaranteed that the only <mprotect> called in LuaJIT runtime locates in > <mcode_protect> (that is not true for Tarantool, so the test is disabled > for integration testing routine). Furthermore, overloading <mprotect> on > macOS occurs to be not an easy ride either, so running the test on macOS > is disabled, since this is the common part for all platforms and > everything can be checked on Linux in a much more easier way. > > Igor Munkin: > * added the description and the test for the problem > > Part of tarantool/tarantool#8825 > > Signed-off-by: Igor Munkin <imun@tarantool.org> > --- > > Branch: https://github.com/tarantool/luajit/tree/imun/lj-802-panic-at-mcode-protfail > Tarantool PR: https://github.com/tarantool/tarantool/pull/9077 > Related issues: > * https://github.com/tarantool/tarantool/issues/8825 > * https://github.com/LuaJIT/LuaJIT/issues/802 > <snipped> > -- > 2.30.2 > -- Best regards, IM
prev parent reply other threads:[~2023-09-27 12:54 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-01 12:46 Igor Munkin via Tarantool-patches 2023-09-03 8:13 ` Sergey Kaplun via Tarantool-patches 2023-09-05 11:31 ` Igor Munkin via Tarantool-patches 2023-09-05 14:20 ` Sergey Kaplun via Tarantool-patches 2023-09-07 10:31 ` Maxim Kokryashkin via Tarantool-patches 2023-09-27 12:33 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZRQg/k04efjoyqMD@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Always exit after machine code page protection change fails.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox