From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] test: fix fix-mips64-spare-side-exit-patching
Date: Tue, 5 Sep 2023 14:16:16 +0300 [thread overview]
Message-ID: <ZPcOACxfDxdpbHEo@root> (raw)
In-Reply-To: <gdujsakhpm22bhpgernxkkox62ft3zx4syqzgoaxedtatuypoy@yjmpq3eouf3d>
Hi, Maxim!
Thanks for the review!
On 05.09.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> LGTM, except for the single nit regarding the commit message below.
>
> On Mon, Sep 04, 2023 at 06:50:26PM +0300, Sergey Kaplun wrote:
> > This test may be flaky due to a non-monotonic filling of the vector with
> I believe, that 'sparse' is a better fit here then 'non-monotonic'. It
> is just a widely adopted term for vectors like this.
Replaced with sparse, thanks!
>
<snipped>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2023-09-05 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 15:50 [Tarantool-patches] [PATCH luajit 0/3] Fix fix-mips64-spare-side-exit-patching Sergey Kaplun via Tarantool-patches
2023-09-04 15:50 ` [Tarantool-patches] [PATCH luajit 1/3] MIPS: Fix "bad FP FLOAD" assertion Sergey Kaplun via Tarantool-patches
2023-09-05 7:05 ` Maxim Kokryashkin via Tarantool-patches
2023-09-26 18:58 ` Igor Munkin via Tarantool-patches
2023-09-04 15:50 ` [Tarantool-patches] [PATCH luajit 2/3] test: fix `fillmcode()` generator helper Sergey Kaplun via Tarantool-patches
2023-09-05 7:06 ` Maxim Kokryashkin via Tarantool-patches
2023-09-26 18:58 ` Igor Munkin via Tarantool-patches
2023-09-04 15:50 ` [Tarantool-patches] [PATCH luajit 3/3] test: fix fix-mips64-spare-side-exit-patching Sergey Kaplun via Tarantool-patches
2023-09-05 8:56 ` Maxim Kokryashkin via Tarantool-patches
2023-09-05 11:16 ` Sergey Kaplun via Tarantool-patches [this message]
2023-09-26 18:59 ` Igor Munkin via Tarantool-patches
2023-09-27 12:33 ` [Tarantool-patches] [PATCH luajit 0/3] Fix fix-mips64-spare-side-exit-patching Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPcOACxfDxdpbHEo@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 3/3] test: fix fix-mips64-spare-side-exit-patching' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox