From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Fix binary number literal parsing. Date: Thu, 31 Aug 2023 15:19:19 +0000 [thread overview] Message-ID: <ZPCvdwjdZtOylI5a@tarantool.org> (raw) In-Reply-To: <20230824100233.25009-1-skaplun@tarantool.org> Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 24.08.23, Sergey Kaplun via Tarantool-patches wrote: > From: Mike Pall <mike> > > Reported by Egor Skriptunoff. > > (cherry-picked from commit 377a8488b62a9f1b589bb68875dd1288aa70e76e) > > Binary number with fractional part is invalid. Parsing of such binary > numbers returns `STRSCAN_ERROR` for any numbers with non-zero fractional > part, because it gives non-zero power of the exponent (`ex2`) in > `strscan_bin()`. But binary numbers with a zero fractional part > considered as valid numbers. To avoid such inconsistency the check, that > the given base doesn't equal 2, is added, when parsing decimal point > part of the literal. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#8825 > --- > > Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-binary-number-parsing > Issue: https://github.com/tarantool/tarantool/issues/8825 > ML: https://www.freelists.org/post/luajit/Fractional-binary-number-literals > Tarantool PR: https://github.com/tarantool/tarantool/pull/9028 > > Tarantool's CI is red, because static build on aarch64 can't fetch the > LuaJIT's submodule commit somehow. Looks unrelated to the commit:). > > src/lj_strscan.c | 1 + > .../fix-binary-number-parsing.test.lua | 17 +++++++++++++++++ > 2 files changed, 18 insertions(+) > create mode 100644 test/tarantool-tests/fix-binary-number-parsing.test.lua > <snipped> > -- > 2.41.0 > -- Best regards, IM
prev parent reply other threads:[~2023-08-31 15:37 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-24 10:02 Sergey Kaplun via Tarantool-patches 2023-08-25 10:12 ` Maxim Kokryashkin via Tarantool-patches 2023-08-25 12:01 ` Sergey Kaplun via Tarantool-patches 2023-08-28 14:02 ` Sergey Bronnikov via Tarantool-patches 2023-08-31 15:19 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZPCvdwjdZtOylI5a@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix binary number literal parsing.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox