Re: [Tarantool-patches] [PATCH luajit 0/5] Fix pow inconsistencies and improve asserts

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in master, release/2.11 and
release/2.10.

On 15.08.23, Sergey Kaplun via Tarantool-patches wrote:
> This patchset fix `^` operator insconsistencies. Since the last 2
> commits are based on the patch "Improve assertions." (*) it is backported as
> well (it's about time).
> 
> (*) Be aware that assertions in <src/luajit.c> aren't replaced in the
> upstream too.
> The following functions/modules contains our own code with assertions,
> so we can discuss some better namings for them:
> * `lj_fullhash()` in <src/lj_str.c>
> * `lua_hashstring()` in <src/lj_api.c>
> * <src/lib_misc.c>
> * <src/lj_mapi.c>
> * <src/lj_memprof.c>
> * <src/lj_sysprof.c>
> * <src/lj_utils_leb128.c>
> * <src/lj_wbuf.c>
> 
> P.S. Unfortunately, I can't find any reproducer for dropping
> optimization of 2 ^ i => ldexp(1.0, i). Please, guide me, if you may
> found any.
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-9-pow-inconsistencies
> PR: https://github.com/tarantool/tarantool/pull/8985
> Related issues:
> * https://github.com/tarantool/tarantool/issues/8825
> * https://github.com/LuaJIT/LuaJIT/issues/9
> * https://github.com/LuaJIT/LuaJIT/issues/684
> * https://github.com/LuaJIT/LuaJIT/issues/817
> 
> 
> Mike Pall (4):
>   Remove pow() splitting and cleanup backends.
>   Improve assertions.
>   Fix pow() optimization inconsistencies.
>   Revert to trival pow() optimizations to prevent inaccuracies.
> 
> Sergey Kaplun (1):
>   test: introduce `samevalues()` TAP checker
> 

<snipped>

> 
> -- 
> 2.41.0
> 

-- 
Best regards,
IM