From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8FFB6608E87; Thu, 31 Aug 2023 18:35:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8FFB6608E87 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693496152; bh=t7oxsBeKNMhZY2VmDVCF10k0+0Y4Y+pgxZWsbw3lFPI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WEFFR4MHOfCgrv8ju4tq5NGfgkrKpSUl23y58oIAO9VZArVR5JjIod1IkofXOVzje jSxzhZZJ2ihZnu7aR+sGxY3JM5iuBXd6JTaRvuimNgBtx0baHCpz8TPUJYggiF3JUL ZowOetInIQYhpBbHjek2hDfzrAY2GzHhchn8CZgw= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1A99F608E87 for ; Thu, 31 Aug 2023 18:35:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1A99F608E87 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1qbji2-00Casf-1L; Thu, 31 Aug 2023 18:35:50 +0300 Date: Thu, 31 Aug 2023 15:18:27 +0000 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96E142CFC92DB15CDBADBDDCFFE5033A370A9F145D9D5274F182A05F538085040DBB837C0E51F9CAE5621E26E376702B7D168673BD11F893297CBE820FF666B4D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7227E4400968B082FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B2BC59D094D41B978638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C4B879C882444CB9AA6BFA3C95F98218117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC990B2EB4F061288CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB1593CA6EC85F86DB78CF848AE20165DD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3457EE4B4996FC5466E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377870F476E0DB9443EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A538E31A2F557FDD25D03F18C3D53947B3A5BB2383CD4DD81EF87CCE6106E1FC07E67D4AC08A07B9B0AD74539164518AE5CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34B7CBFF60649FF26695F4D436E6988CF34D0C01C3D4862A7C5FDA862AF12F400069AEEF26642DE6731D7E09C32AA3244C466086AFF91A060EE34D663AEF3B4F1624AF4FAF06DA24FDBAD658CF5C8AB4025DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6jqRMsEo8wfbSc9BszEFRw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D5318D99D21FB4EC48989EADE00B8D6185373893FEE2500F63042326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 0/5] Fix pow inconsistencies and improve asserts X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in master, release/2.11 and release/2.10. On 15.08.23, Sergey Kaplun via Tarantool-patches wrote: > This patchset fix `^` operator insconsistencies. Since the last 2 > commits are based on the patch "Improve assertions." (*) it is backported as > well (it's about time). > > (*) Be aware that assertions in aren't replaced in the > upstream too. > The following functions/modules contains our own code with assertions, > so we can discuss some better namings for them: > * `lj_fullhash()` in > * `lua_hashstring()` in > * > * > * > * > * > * > > P.S. Unfortunately, I can't find any reproducer for dropping > optimization of 2 ^ i => ldexp(1.0, i). Please, guide me, if you may > found any. > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-9-pow-inconsistencies > PR: https://github.com/tarantool/tarantool/pull/8985 > Related issues: > * https://github.com/tarantool/tarantool/issues/8825 > * https://github.com/LuaJIT/LuaJIT/issues/9 > * https://github.com/LuaJIT/LuaJIT/issues/684 > * https://github.com/LuaJIT/LuaJIT/issues/817 > > > Mike Pall (4): > Remove pow() splitting and cleanup backends. > Improve assertions. > Fix pow() optimization inconsistencies. > Revert to trival pow() optimizations to prevent inaccuracies. > > Sergey Kaplun (1): > test: introduce `samevalues()` TAP checker > > > -- > 2.41.0 > -- Best regards, IM