Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix TDUP load forwarding after table rehash.
Date: Mon, 28 Aug 2023 17:26:07 +0300	[thread overview]
Message-ID: <ZOyuf57f1aST-Kwa@root> (raw)
In-Reply-To: <5c416cf4-f366-9f35-f05b-13f1c7679749@tarantool.org>

Hi, Sergey!
Thanks for the review!
Please, see my answers below.

On 28.08.23, Sergey Bronnikov wrote:
> Sergey,
> thanks for the patch. See my comment inline.


> Is it possible to fold loop bodies to a single function?
> Otherwise it is too much duplicate code in the test.

I prefer not to do it since:
* It's complicated traces, so it's harder to understand what is this
  test about.
* Some function's may be recorded instead, so the issue will not
  occure. Or test becomes flaky.

Best regards,
Sergey Kaplun

  reply	other threads:[~2023-08-28 14:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 14:46 Sergey Kaplun via Tarantool-patches
2023-08-20 12:13 ` Maxim Kokryashkin via Tarantool-patches
2023-08-21  8:58   ` Sergey Kaplun via Tarantool-patches
2023-08-28 14:25 ` Sergey Bronnikov via Tarantool-patches
2023-08-28 14:26   ` Sergey Kaplun via Tarantool-patches [this message]
2023-08-28 14:33     ` Sergey Bronnikov via Tarantool-patches
2023-08-31 15:19 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOyuf57f1aST-Kwa@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Fix TDUP load forwarding after table rehash.' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox