From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B2CD75C2D8C; Mon, 28 Aug 2023 17:30:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2CD75C2D8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693233054; bh=bAfJS6HvIX21imAgUY5sKX4gYPSRvbU38vKy9ux8LyE=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=R+Kyl/EibQpPxR6v+VW6sd3bNc2tbAoFrQpkM4CcUz0V9K5g/gO3eav/3NSqWCJZR cQp6kyh4R9KR+KTgNaO+ToI5oHnrafNuW4VwSdJ2/1xcu1U7YVYLcB53fb10IqINGA Bwh5JF//kh2RbLOdHET27rpz6vjnzXTvisqwiq5k= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [95.163.41.96]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 67F0F5C1DB4 for ; Mon, 28 Aug 2023 17:30:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 67F0F5C1DB4 Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1qadGW-00GIuB-0Q; Mon, 28 Aug 2023 17:30:52 +0300 Date: Mon, 28 Aug 2023 17:26:07 +0300 To: Sergey Bronnikov Message-ID: References: <20230817144641.20088-1-skaplun@tarantool.org> <5c416cf4-f366-9f35-f05b-13f1c7679749@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c416cf4-f366-9f35-f05b-13f1c7679749@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9954329A9C7AF96E9E2DDB7AE4AB0A4FB6A2275B35D8A45EC182A05F5380850401E4B88CB37106698417BA71AC41D5407541E59565E2F38312E772F064DB4DBE6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE731D82F3F177D3BCDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371DF52D98DC3592C48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D823ADF5C1D7BEE93063623E020EB85C14117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCA2FFE18CF0BA0C38A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD2882943172349060D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D886136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C3090DF2C0002BD1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5E408DC58FDF443E456F123EDEB8B437B800696E7FB627DA2F87CCE6106E1FC07E67D4AC08A07B9B09E541A154B51D14BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3419891600CCEF46070AB73EB088A45A009709320A6098CCED1CB200AA9856FF128F502DD63F391F211D7E09C32AA3244C78188658AF6C240F9BFF252D5362158B3FD9C8CA1B0515E085A42E4C463514DC5DA084F8E80FEBD3202CD0F03380D9577A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrC6BcuK2ROwq0jRy059qDg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76966FB934F58841A94417BA71AC41D540779D0F6AC9C0BD8DBDEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix TDUP load forwarding after table rehash. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please, see my answers below. On 28.08.23, Sergey Bronnikov wrote: > Sergey, > > > thanks for the patch. See my comment inline. > > > > Is it possible to fold loop bodies to a single function? > > Otherwise it is too much duplicate code in the test. I prefer not to do it since: * It's complicated traces, so it's harder to understand what is this test about. * Some function's may be recorded instead, so the issue will not occure. Or test becomes flaky. -- Best regards, Sergey Kaplun