Re: [Tarantool-patches] [PATCH luajit] Fix maxslots when recording BC_TSETM.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!

On 28.08.23, Sergey Bronnikov wrote:
> Hi, Sergey
> 
> 
> thanks for the patch! LGTM
> 
> See a minor comment inline.
> 
> 
> Sincerely yours,
> 
> Sergey
> 
> 
> On 8/25/23 18:00, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Analyzed by Sergey Kaplun.
> >

<snipped>

> 
> I've discovered that bug is not reproduced when LUAJIT_ENABLE_TABLE_BUMP 
> is enabled, by default it is disabled.
> 
> CFLAGS="-DLUAJIT_ENABLE_TABLE_BUMP" cmake -S . -B build 
> -DCMAKE_BUILD_TYPE=Debug
> 
> cmake --build build --parallel
> 
> It is probably worth to mention in commit message. Feel free to ignore.

I suppose, since it's not enabled by default it's better to ignore it.
It's  hidden due-to DCE optimizations, most probably.

Ignoring.

> 
> 
> 
> <snipped>
> 

-- 
Best regards,
Sergey Kaplun