From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <max.kokryashkin@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/2 v8] test: don't skip tool CLI flag for tarantool
Date: Mon, 28 Aug 2023 14:21:38 +0300 [thread overview]
Message-ID: <ZOyDQpLUqWeYRSAO@root> (raw)
In-Reply-To: <fc67651d7a39ba9bff66404095088ff126314aba.1692954427.git.m.kokryashkin@tarantool.org>
Hi, Maxim!
Thanks for the patch!
LGTM, as trivial, with a single nit regarding the commit message.
On 25.08.23, Maxim Kokryashkin wrote:
> That skipcond was introduced to overcome the obstacles
> of LuaJIT's integrational testing in Tarantool. Since
Typo: s/integrational/integration/
> the required patch is now in the Tarantool master, this
> skipcond is now unnecessary.
>
> Related to tarantool/tarantool#5688
> ---
<snipped>
--
Best regards,
Sergey Kaplun
prev parent reply other threads:[~2023-08-28 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 9:14 [Tarantool-patches] [PATCH luajit 0/2 v8] introduce cli for tools Maxim Kokryashkin via Tarantool-patches
2023-08-25 9:14 ` [Tarantool-patches] [PATCH luajit 1/2 v8] tools: add cli flag to run profile dump parsers Maxim Kokryashkin via Tarantool-patches
2023-08-28 11:17 ` Sergey Kaplun via Tarantool-patches
2023-08-25 9:14 ` [Tarantool-patches] [PATCH luajit 2/2 v8] test: don't skip tool CLI flag for tarantool Maxim Kokryashkin via Tarantool-patches
2023-08-28 11:21 ` Sergey Kaplun via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOyDQpLUqWeYRSAO@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/2 v8] test: don'\''t skip tool CLI flag for tarantool' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox