Re: [Tarantool-patches] [PATCH luajit] Fix maxslots when recording BC_TSETM.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the comments!
Fixed your comments inline.

On 28.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the fixes!
> LGTM, except for a few more comments below.
> On Mon, Aug 28, 2023 at 06:02:12PM +0300, Sergey Kaplun wrote:

<snipped>

> > > > +
> > > > +local TEST_VALUE = '5'
> > > > +local TEST_IDX = 5
> > > > +
> > > > +local function slot5()
> > > > +  return nil, nil, nil, nil, TEST_VALUE
> > > > +end
> > > Why the fifth slot? Drop a comment.
> > 
> > Fixed. See the iterative patch below.
> > 

<snipped>

> > 
> > ===================================================================
> > diff --git a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua
> > index 7ae0a99d..74625a79 100644
> > --- a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua
> > +++ b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua
> > @@ -15,6 +15,8 @@ local jit_dump = require('jit.dump')
> >  local TEST_VALUE = '5'
> >  local TEST_IDX = 5
> >  
> > +-- XXX: Use big enough slot numbewr to be overwritten by VM event
> Typo: s/Use/Use a/
> Typo: s/numbewr/number/
> Typo: s/by VM/by the VM/
> > +-- handler function.
> Please also add that this is an empirical number.

Fixed, thanks.

===================================================================
diff --git a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua
index 74625a79..0e82c0b9 100644
--- a/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua
+++ b/test/tarantool-tests/lj-1025-tsetm-maxslot.test.lua
@@ -15,8 +15,8 @@ local jit_dump = require('jit.dump')
 local TEST_VALUE = '5'
 local TEST_IDX = 5
 
--- XXX: Use big enough slot numbewr to be overwritten by VM event
--- handler function.
+-- XXX: Use a big enough slot number to be overwritten by the VM
+-- event handler function. This value is empirical.
 local function slot5()
   return nil, nil, nil, nil, TEST_VALUE
 end
===================================================================

<snipped>

-- 
Best regards,
Sergey Kaplun