From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maksim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v4 1/3] sysprof: remove `split by vmstate` option Date: Mon, 21 Aug 2023 13:05:54 +0000 [thread overview] Message-ID: <ZONhMjKTL3S6VSgF@tarantool.org> (raw) In-Reply-To: <20230821100604.61363-2-max.kokryashkin@gmail.com> Max, Thanks for the fixes! LGTM, but still one nit regarding the wording. On 21.08.23, Maksim Kokryashkin wrote: > From: Maxim Kokryashkin <m.kokryashkin@tarantool.org> > > The option was introduced early into the sysprof's > development to provide capabilities for per-VM-state > callchain visualization. However, during the sysprof's > recent active in-house usage period, it became clear > that performance issues associated with specific VM > states (such as GC, for example) have a distinct look > on a flamegraph itself, thanks to their name prefixes > and their surrounding context. Minor: Besides, one can still use counters returned by <sysprof.report>, right? If so, it would be nice to mention this in reasoning too. > > This option is unneeded and was never used > by anybody. There is no reason to maintain it > in the scope of refactoring. > > Needed for tarantool/tarantool#8700 > --- > tools/sysprof.lua | 9 +-------- > tools/sysprof/collapse.lua | 10 +++------- > 2 files changed, 4 insertions(+), 15 deletions(-) > <snipped> > -- > 2.39.2 (Apple Git-143) > -- Best regards, IM
next prev parent reply other threads:[~2023-08-21 13:22 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-21 10:06 [Tarantool-patches] [PATCH luajit v4 0/3] sysprof: parser refactoring Maksim Kokryashkin via Tarantool-patches 2023-08-21 10:06 ` [Tarantool-patches] [PATCH luajit v4 1/3] sysprof: remove `split by vmstate` option Maksim Kokryashkin via Tarantool-patches 2023-08-21 13:05 ` Igor Munkin via Tarantool-patches [this message] 2023-08-21 13:37 ` Maxim Kokryashkin via Tarantool-patches 2023-08-21 10:06 ` [Tarantool-patches] [PATCH luajit v4 2/3] tools: add execution permission to sysprof parser Maksim Kokryashkin via Tarantool-patches 2023-08-21 10:06 ` [Tarantool-patches] [PATCH luajit v4 3/3] sysprof: improve parser's memory footprint Maksim Kokryashkin via Tarantool-patches 2023-08-21 13:05 ` Igor Munkin via Tarantool-patches 2023-08-31 15:17 ` [Tarantool-patches] [PATCH luajit v4 0/3] sysprof: parser refactoring Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZONhMjKTL3S6VSgF@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit v4 1/3] sysprof: remove `split by vmstate` option' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox