From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 36288599298; Mon, 21 Aug 2023 16:22:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 36288599298 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692624129; bh=zcIeP6LAQ3Je7R9R53TUiiDnATw6vx3HDP4Ah8X5y8I=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZpuyytRKg8LmDwDFnfQmqkVj7hb9nYWHZrLwYizeL/Vsn+itCMqwz4c1T31OBANo9 DkZfgLZTYV/9IxjW7S3sB2rboe+oM19FqrIqsV6FvuDG3W1e9sd2ELnVPczd1psJFf poaDlDozOc6cWWCKrwbYahIyW8TvA7VeSoJSDvzU= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [95.163.41.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B03CA59568B for ; Mon, 21 Aug 2023 16:21:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B03CA59568B Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1qY4qq-001g2s-0D; Mon, 21 Aug 2023 16:21:48 +0300 Date: Mon, 21 Aug 2023 13:05:54 +0000 To: Maksim Kokryashkin Message-ID: References: <20230821100604.61363-1-max.kokryashkin@gmail.com> <20230821100604.61363-2-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230821100604.61363-2-max.kokryashkin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD90D1D1AB54508998164C3387BA0FA5B81EA24825B1EA10A89182A05F5380850404C228DA9ACA6FE272F99B7004A01D1DCAF165521F19ACC473F0F223EBB7766AE23ED34896A89E76D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75DF2B1F23425CAE5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637352A1F9739ED04D38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D878AFFEEEBD7014CB7E72100041AB8CEF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2D1539C52A686690A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE0AC5B80A05675ACD07FB45A5F6E725C8D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3F8BD4E506CFA3D889735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BF1C901A33650803EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A560ACAD919A034A25CFC133FFA660B071D50A6C4727D14192F87CCE6106E1FC07E67D4AC08A07B9B08ED1AC82D843A2BBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340EEB18E49183157152FAC98ECD0AEF0623DBD22A3ED74C875347431121623D81F7C7CA26B16302571D7E09C32AA3244CECCA784D298BC86493B9F80AB8F54FC4725D5B54B2FE4575ED9A463B7D0AAFF65DA084F8E80FEBD376A4ED3E9341DC2FCD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHJI2DMjVra1oYgQfnFxsXA== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531A1AE1FF5939ED19C767D89112C756D7FB59D37FE87E49B362326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 1/3] sysprof: remove `split by vmstate` option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for the fixes! LGTM, but still one nit regarding the wording. On 21.08.23, Maksim Kokryashkin wrote: > From: Maxim Kokryashkin > > The option was introduced early into the sysprof's > development to provide capabilities for per-VM-state > callchain visualization. However, during the sysprof's > recent active in-house usage period, it became clear > that performance issues associated with specific VM > states (such as GC, for example) have a distinct look > on a flamegraph itself, thanks to their name prefixes > and their surrounding context. Minor: Besides, one can still use counters returned by , right? If so, it would be nice to mention this in reasoning too. > > This option is unneeded and was never used > by anybody. There is no reason to maintain it > in the scope of refactoring. > > Needed for tarantool/tarantool#8700 > --- > tools/sysprof.lua | 9 +-------- > tools/sysprof/collapse.lua | 10 +++------- > 2 files changed, 4 insertions(+), 15 deletions(-) > > -- > 2.39.2 (Apple Git-143) > -- Best regards, IM