Re: [Tarantool-patches] [PATCH luajit 4/5] Fix pow() optimization inconsistencies.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
Fixed your comments inline.

On 18.08.23, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> 
> thanks for the patch! LGTM with two minor comments inline.
> 
> 
> On 8/15/23 12:36, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > (cherry-picked from commit 9512d5c1aced61e13e7be2d3208ec7ae3516b458)
> >
> > This patch fixes different misbehaviour between JIT-compiled code and
> misbehaviour -> misbehaviours

Fixed.

> > the interpreter for power operator with the following ways:
> > * Drop folding optimizations for base ^ 0.5 => sqrt(base), as far as
> >    pow(base, 0.5) isn't interchangeable and depends on the <math.h>
> >    implementation.
> > * Drop folding optimizations for 2 ^ int_pow => ldexp(1.0, int_pow), to
> >    avoid dependcy on the <math.h> implementation.
> dependcy -> dependency

Fixed.

> > * Now `asm_pow()` always assemble a call to the `lj_vm_powi()` function,

<snipped>

-- 
Best regards,
Sergey Kaplun