Re: [Tarantool-patches] [PATCH luajit 05/19] PPC: Add soft-float support to interpreter.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!
Fixed your comments inline.

On 15.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few comments below.
> On Wed, Aug 09, 2023 at 06:35:54PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> > From: Mike Pall <mike>
> > 
> > Contributed by Djordje Kovacevic and Stefan Pejic from RT-RK.com.
> > Sponsored by Cisco Systems, Inc.
> > 
> > (cherry-picked from commit 71b7bc88341945f13f3951e2bb5fd247b639ff7a)
> > 
> > The software floating point library is used on machines which do not
> > have hardware support for floating point [1]. This patch enables
> > support for such machines in the VM for powerpc.
> Typo: s/powerpc/PowerPC/

Fixed, thanks.

> > This includes:
> > * Any loads/storages of double values use load/storage through 32-bit
> Typo: s/storages/stores/ Feel free to ignore, though.

Fixed, thanks.

> >   registers of `lo` and `hi` part of the TValue union.
> > * Macro .FPU is added to skip instructions necessary only for
> >   hard-float operations (load/store floating point registers from/on the
> >   stack, when leave/enter VM, for example).
> Typo: s/leave/enter/leaving/entering/

Fixed, thanks!

> > * Now r25 named as `SAVE1` is used as saved temporary register (used in
> >   different fast functions)
> > * `sfi2d` macro is introduced to convert integer, that represents a
> Typo: s/convert/convert an/

Fixed.

> >   soft-float, to double. Receives destination and source registers, uses
> Typo: s/to double/to a double/

Fixed.

> >   `TMP0` and `TMP1`.
> > * `sfpmod` macro is introduced for soft-float point `fmod` built-in.
> > * `ins_arith` now receives the third parameter -- operation to use for
> >   soft-float point.
> > * `LJ_ARCH_HASFPU`, `LJ_ABI_SOFTFP` macros are introduced to mark that
> >   there is defined `_SOFT_FLOAT` or `_SOFT_DOUBLE`. `LJ_ARCH_NUMMODE` is
> >   set to the `LJ_NUMMODE_DUAL`, when `LJ_ABI_SOFTFP` is true.
> > 
> > Support of soft-float point for the JIT compiler will be added in the
> > next patch.
> > 
> > [1]: https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html
> > 
> > Sergey Kaplun:
> > * added the description for the feature
> > 
> > Part of tarantool/tarantool#8825
> > ---

<snipped>

> > 

-- 
Best regards,
Sergey Kaplun