Re: [Tarantool-patches] [PATCH luajit 04/19] MIPS64: Add soft-float support to JIT compiler backend.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!
Fixed your comments inline.

On 15.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> LGTM, except for a few comments below.
> On Wed, Aug 09, 2023 at 06:35:53PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> > From: Mike Pall <mike>
> > 
> > Contributed by Djordje Kovacevic and Stefan Pejic from RT-RK.com.
> > Sponsored by Cisco Systems, Inc.
> > 
> > (cherry-picked from commit a057a07ab702e225e21848d4f918886c5b0ac06b)
> > 
> > The software floating point library is used on machines which do not
> > have hardware support for floating point [1]. This patch enables
> > support for such machines in JIT compiler backend for MIPS64.
> Typo: s/in JIT/in the JIT/

Fixed.

> > This includes:
> > * `vm_tointg()` helper is added in <src/vm_mips64.dasm> to convert FP
> >   number to integer with a check for the soft-float support (called from
> >   JIT).
> > * `sfmin/max()` helpers are added in <src/vm_mips64.dasm> for min/max
> >   operations with a check for the soft-float support (called from JIT).
> Typo: s/the soft-float/soft-float/

Fixed.

> > * `LJ_SOFTFP32` macro is introduced to be used for 32-bit MIPS instead
> >   `LJ_SOFTFP`.
> > * All fp-depending paths are instrumented with `LJ_SOFTFP` or
> Typo: s/fp-depending/fp-dependent/

Fixed.

> >   `LJ_SOFTFP32` macro.
> Typo: s/macro/macros/

Fixed.

> > * The corresponding function calls in <src/lj_ircall.h> are marked as
> >   `XA_FP32`, `XA2_FP32`, i.e. as required extra arguments on the stack
> >   for soft-FP on 32-bit MIPS.
> 
> Shouldn't we also mention the `asm_tobit` function?

I suppose no, since it still just another implementation for SOFTFP &&
LJ_64 mode.

> > 
> > [1]: https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html
> > 
> > Sergey Kaplun:
> > * added the description for the feature
> > 
> > Part of tarantool/tarantool#8825
> > ---

<snipped>

> > 

-- 
Best regards,
Sergey Kaplun