From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <max.kokryashkin@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v3 1/4] utils: remove unnecessary insertion in AVL-tree Date: Tue, 15 Aug 2023 18:50:45 +0000 [thread overview] Message-ID: <ZNvJBTpY/IRXcnC+@tarantool.org> (raw) In-Reply-To: <ca68d6ed31c20b0f8a3a48633a4d84ecf6633e87.1690834846.git.m.kokryashkin@tarantool.org> Max, Thanks for the patch! The change is quite clear, but so-called 'gen' was introduced on purpose AFAIR. Hence, I would like to ask you to describe this change or clarify my gen misunderstanding. On 31.07.23, Maxim Kokryashkin wrote: > This patch fixes a bug in the AVL-tree implementation, > which produced unnecessary inserts of values into nodes, > instead of replacement. > > Needed for tarantool/tarantool#8700 > --- > .../tarantool-tests/gh-5813-resolving-of-c-symbols.test.lua | 6 ++---- > tools/utils/avl.lua | 4 ++-- > tools/utils/symtab.lua | 2 +- > 3 files changed, 5 insertions(+), 7 deletions(-) > <snipped> > -- > 2.41.0 > -- Best regards, IM
next prev parent reply other threads:[~2023-08-15 19:05 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-31 20:30 [Tarantool-patches] [PATCH luajit v3 0/4] sysprof: parser refactoring Maxim Kokryashkin via Tarantool-patches 2023-07-31 20:30 ` [Tarantool-patches] [PATCH luajit v3 1/4] utils: remove unnecessary insertion in AVL-tree Maxim Kokryashkin via Tarantool-patches 2023-08-15 18:50 ` Igor Munkin via Tarantool-patches [this message] 2023-07-31 20:30 ` [Tarantool-patches] [PATCH luajit v3 2/4] sysprof: remove `split by vmstate` option Maxim Kokryashkin via Tarantool-patches 2023-08-15 18:51 ` Igor Munkin via Tarantool-patches 2023-07-31 20:30 ` [Tarantool-patches] [PATCH luajit v3 3/4] tools: add execution permission to sysprof parser Maxim Kokryashkin via Tarantool-patches 2023-08-15 18:51 ` Igor Munkin via Tarantool-patches 2023-07-31 20:30 ` [Tarantool-patches] [PATCH luajit v3 4/4] sysprof: improve parser's memory footprint Maxim Kokryashkin via Tarantool-patches 2023-08-15 18:52 ` Igor Munkin via Tarantool-patches 2023-08-15 18:54 ` [Tarantool-patches] [PATCH luajit v3 0/4] sysprof: parser refactoring Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZNvJBTpY/IRXcnC+@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --subject='Re: [Tarantool-patches] [PATCH luajit v3 1/4] utils: remove unnecessary insertion in AVL-tree' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox