From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch
Date: Wed, 9 Aug 2023 17:40:28 +0300 [thread overview]
Message-ID: <ZNOlXFAXH0A6goxo@root> (raw)
In-Reply-To: <0b4e13bb2bfeea5812e9bb8cee02cb706c9f1175.1690966149.git.sergeyb@tarantool.org>
Hi, Sergey!
Thanks for the patch!
LGTM, except a single nit regarding the commit message.
On 02.08.23, Sergey Bronnikov wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Patch adds a GitHub Action, that clones checkpatch repository, and adds
Typo: s/Patch/The patch/
> a job, that runs checkpatch [1] using CMake target "LuaJIT-checkpatch"
> against commits on top of the master branch.
>
<snipped>
>
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2023-08-09 14:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 8:52 [Tarantool-patches] [PATCH 0/5][v3] Fix typos and " Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 1/5][v3] ci: fix a step name Sergey Bronnikov via Tarantool-patches
2023-08-03 19:27 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 11:20 ` Sergey Kaplun via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-08-03 19:29 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 12:58 ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:41 ` Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38 ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:56 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:04 ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:55 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 15:45 ` Sergey Kaplun via Tarantool-patches
2023-08-15 8:57 ` Maxim Kokryashkin via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38 ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 14:40 ` Sergey Kaplun via Tarantool-patches [this message]
2023-08-09 15:05 ` Sergey Bronnikov via Tarantool-patches
2023-08-14 9:22 ` Sergey Bronnikov via Tarantool-patches
2023-08-02 8:52 ` [Tarantool-patches] [PATCH 5/5][v3] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-08-03 19:45 ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:42 ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:07 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNOlXFAXH0A6goxo@root \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox