Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos
Date: Wed, 9 Aug 2023 15:58:00 +0300	[thread overview]
Message-ID: <ZNONWOlzpcHfC9nZ@root> (raw)
In-Reply-To: <d3d8d352854492f36dcfc1264930e04010f69110.1690966149.git.sergeyb@tarantool.org>

Hi, Sergey!
Thanks for the patch!
It's LGTM, but I found more spellcheck errors in the code in:

* <src/*> files, that are maintained by us
| ./src/lj_memprof.c:261: resourses ==> resources
| ./src/lj_memprof.c:390: resourses ==> resources

* <test/LuaJIT-tests/> since they are not probably be updated ever in
  future:
| ./test/LuaJIT-tests/README.md:46: alot ==> a lot, allot

* <test/PUC-Rio-Lua-5.1-tests/> since they are not be updated ever in
  future:
| ./test/PUC-Rio-Lua-5.1-tests/api.lua:20: allignment ==> alignment
| ./test/PUC-Rio-Lua-5.1-tests/api.lua:336: acess ==> access
| ./test/PUC-Rio-Lua-5.1-tests/db.lua:564: acessing ==> accessing
| ./test/PUC-Rio-Lua-5.1-tests/gc.lua:311: ressurect ==> resurrect
| ./test/PUC-Rio-Lua-5.1-tests/locals.lua:118: fiels ==> feels, fields, files, phials
| ./test/PUC-Rio-Lua-5.1-tests/math.lua:168: convertions ==> conversions
| ./test/PUC-Rio-Lua-5.1-tests/strings.lua:159: formated ==> formatted

* <test/lua-Harness-tests/*> -- this is debatable, since this part isn't
  maintained by us (we still may apply patches from the upstream).
| ./test/lua-Harness-tests/231-metatable.t:398: heigth ==> height
| ./test/lua-Harness-tests/232-object.t:119: insuficient ==> insufficient
| ./test/lua-Harness-tests/232-object.t:133: insuficient ==> insufficient
| ./test/lua-Harness-tests/232-object.t:93: classe ==> class, classes
| ./test/lua-Harness-tests/241-standalone.t:241: runned ==> ran, run, ruined
| ./test/lua-Harness-tests/242-luac.t:275: endianess ==> endianness

* <test/tarantool-tests/*>:
| ./test/tarantool-tests/lj-350-sload-typecheck.test.lua:2: asembling ==> assembling
| ./test/tarantool-tests/lj-357-arm64-hrefk.test.lua:20: invarinat ==> invariant
| ./test/tarantool-tests/misclib-memprof-lapi.test.lua:2: indepentent ==> independent

<snipped>

-- 
Best regards,
Sergey Kaplun

  parent reply	other threads:[~2023-08-09 13:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  8:52 [Tarantool-patches] [PATCH 0/5][v3] Fix typos and enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 1/5][v3] ci: fix a step name Sergey Bronnikov via Tarantool-patches
2023-08-03 19:27   ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 11:20   ` Sergey Kaplun via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos Sergey Bronnikov via Tarantool-patches
2023-08-03 19:29   ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 12:58   ` Sergey Kaplun via Tarantool-patches [this message]
2023-08-09 14:41     ` Sergey Bronnikov via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38   ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:56     ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:04       ` Sergey Kaplun via Tarantool-patches
2023-08-09 14:55         ` Sergey Bronnikov via Tarantool-patches
2023-08-09 15:45           ` Sergey Kaplun via Tarantool-patches
2023-08-15  8:57           ` Maxim Kokryashkin via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 4/5][v3] ci: enable checkpatch Sergey Bronnikov via Tarantool-patches
2023-08-03 19:38   ` Maxim Kokryashkin via Tarantool-patches
2023-08-09 14:40   ` Sergey Kaplun via Tarantool-patches
2023-08-09 15:05     ` Sergey Bronnikov via Tarantool-patches
2023-08-14  9:22     ` Sergey Bronnikov via Tarantool-patches
2023-08-02  8:52 ` [Tarantool-patches] [PATCH 5/5][v3] test: fix codestyle Sergey Bronnikov via Tarantool-patches
2023-08-03 19:45   ` Maxim Kokryashkin via Tarantool-patches
2023-08-04 10:42     ` Sergey Bronnikov via Tarantool-patches
2023-08-09 14:07   ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNONWOlzpcHfC9nZ@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=max.kokryashkin@gmail.com \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 2/5][v3] codehealth: fix typos' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox