Re: [Tarantool-patches] [PATCH 3/5][v3] cmake: introduce new targets

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the fixes!

On 09.08.23, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> On 8/9/23 17:04, Sergey Kaplun wrote:

<snipped>

> >>    include(LuaJITUtils)
> >>    include(SetBuildParallelLevel)
> >>    include(SetVersion)
> >> +include(CheckPatch)
> > And be included from test/CMakeLists.txt, not from root CMakeLists.txt.
> Why? How checkpatch is related to testing?

Not so much, but we still have `LuaJIT-luacheck` target in testing. I
expected the same from `LuaJIT-checkpatch` target (and `test` target
depends on `LuaJIT-checkpatch` target).

But we may also move `LuaJIT-luacheck` in the separate include file in the
separate patch series.

> >

<snipped>

> >> +    WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
> > Also, we can't just check all patches with this since it will have
> > TONS of errors. We must at least exclude all <src/*>, <dynasm/*> and
> > include back files that are maintained by us.
> >
> > Without this, it becomes pointless, since we either
> > * will have red always checkpatch job and don't be aware, so can miss
> >    some errors, either
> > * will set ignore all (or something like it) to ignore all checkpatch
> >    warnings, including meaningful one.
> 
> Agree, but this requires patching checkpatch itself, right now it is not 
> possible
> 
> to suppress warnings for a certain files in patch. I'll try to implement 
> such patch.

Looking forward to it!

> 

<snipped>

-- 
Best regards,
Sergey Kaplun