Re: [Tarantool-patches] [PATCH] cmake: add code coverage support

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the fixes!
LGTM, except the last minor nit ;).

On 08.08.23, Sergey Bronnikov wrote:
> Hello,

<snipped>

> 
> 
> diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
> index 78abf2e1..13ea6c5b 100644
> --- a/.github/workflows/coverage.yml
> +++ b/.github/workflows/coverage.yml
> @@ -50,8 +50,10 @@ jobs:
>         - name: build
>           run: cmake --build . --parallel
>           working-directory: ${{ env.BUILDDIR }}
> -      - name: test and generate code coverage report
> -        run: cmake --build ${{ env.BUILDDIR }} --parallel --target coverage
> +      - name: run regression tests
> +        run: cmake --build ${{ env.BUILDDIR }} --parallel --target test

I suppose it should be LuaJIT-test, since we don't want to run linters
here. See also [1].

> +      - name: generate code coverage report
> +        run: cmake --build ${{ env.BUILDDIR }} --parallel --target LuaJIT-coverage
>         - name: send code coverage to coveralls.io
>           run: |
>             curl -LO https://coveralls.io/coveralls-linux.tar.gz

<snipped>

> >   

[1]: https://github.com/tarantool/luajit/actions/runs/5794532687/job/15704307515#step:7:46

-- 
Best regards,
Sergey Kaplun