Re: [Tarantool-patches] [PATCH luajit 3/5] Improve assertions.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!
I fixed your comments and force-pushed the branch.

On 17.08.23, Maxim Kokryashkin wrote:
> Hi!
> Thanks for the patch!
> LGTM, except for a few comments below.
> 
> Side note: glad to see, that you didn't forget to enable the
> assertions we decided to replace with convetional ones, awesome work!

Nice to hear:).

> On Tue, Aug 15, 2023 at 12:36:29PM +0300, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> > 
> > (cherry-picked from commit 8ae5170cdc9c307bd81019b3e014391c9fd00581)
> > 
> > This commit refactors assertions used in the LuaJIT. It introduces new
> Typo: s/introduces/introduces the/

Fixed, thanks!

> > module <src/lj_assert.c> with the `lj_assert_fail()` implementation.
> > Wrappers of this function are used across the whole code base. Each
> > macro wrapper is defined in the corresponding module gets global state
> Typo: s/module/module and/

Fixed.

> > (if possible) from its environment to be passed inside the assertion.
> > For now, the global state is unused, but later it may be used for
> > dumping of the VM state.
> Typo: s/of the/the/

Fixed.

> > 
> > Sergey Kaplun:
> > * added the description for the feature
> > 
> > Part of tarantool/tarantool#8825
> > ---

<snipped>

> > -- 
> > 2.41.0
> > 

-- 
Best regards,
Sergey Kaplun