Re: [Tarantool-patches] [PATCH luajit 1/5] test: introduce `samevalues()` TAP checker

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Maxim!
Thanks for the review!
Updated the commit message as you suggested.

On 17.08.23, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few comments below.
> 
> On Tue, Aug 15, 2023 at 12:36:27PM +0300, Sergey Kaplun wrote:
> > The introduced `samevalues()` helper checks that values in range from
> Typo: s/in range/in the range/

Fixed.

> > 1, to `table.maxn()` of the given table are exactly the same. It may be
> > usefull for test consistency of JIT and VM behaviour. Originally, the
> Typo: s/usefull for test/useful to test the/

Fixed.

> > `arr_is_consistent()` function was introduced in the
> > <tarantool-tests/gh-6163-min-max.test.lua>. `samevalues()` has the same
> > functionallity (except usage of `table.maxn()` instead `#` operator to
> Typo: s/functionallity/functionality/
> Typo: s/except/except for the/
> Typo: s/instead/instead of the/

Fixed all, thanks!

> > be sure, that the table we check isn't a sparse array).
> > ---

<snipped>

> > 

-- 
Best regards,
Sergey Kaplun