Re: [Tarantool-patches] [PATCH luajit 15/19] Fix LJ_MAX_JSLOTS assertion in rec_check_slots().

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!

On 17.08.23, Sergey Bronnikov wrote:
> Hi, Sergey!
> 
> On 8/9/23 18:36, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Thanks to Yichun Zhang.
> >
> > (cherry-picked from commit 1c89933f129dde76944336c6bfd05297b8d67730)
> >
> > This patch is predecessor for the commit
> > 944d32afd6ddd9dbac1cddf64bf81333efeb9e30 ("Add missing LJ_MAX_JSLOTS
> > check.") It tries to fix the issue, when `J->baseslot == LJ_MAX_JSLOTS`,
> > that leading to the assertion failure. Since the predecessor patch,
> > there are no places, that can lead to the condition failure, since we
> > always check that new baseslot + framesize (+ vargframe) >=
> > `LJ_MAX_JSLOTS`. As far as minimum framesize is 1 (see <src/lj_parse.c>
> > for details), we can't obtain this assertion failure. This patch is
> > added for the consistency with the upstream.
> >
> > Since the predecessor patch fixes the issue, there is no new test case
> > to add.
> >
> > Sergey Kaplun:
> > * added the description for the problem
> Test for backported patch is missing. Why?

As mentioned above there is two separate commits (the current one and
this one [1]). Since the second fixes the issue and was backported
earlier there is no new testcase provided (see the commit message).

> >
> > Part of tarantool/tarantool#8825
> <snipped>

[1]: https://github.com/LuaJIT/LuaJIT/commit/630ff319

-- 
Best regards,
Sergey Kaplun